Bug 218917 - Bring up Big Sur Builders and Testers
Summary: Bring up Big Sur Builders and Testers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Lewis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-13 11:41 PST by Matt Lewis
Modified: 2020-11-17 10:47 PST (History)
4 users (show)

See Also:


Attachments
Patch (8.09 KB, patch)
2020-11-13 12:52 PST, Matt Lewis
no flags Details | Formatted Diff | Diff
Patch (8.09 KB, patch)
2020-11-13 14:46 PST, Matt Lewis
no flags Details | Formatted Diff | Diff
Patch (10.26 KB, patch)
2020-11-13 15:02 PST, Matt Lewis
no flags Details | Formatted Diff | Diff
Patch (11.45 KB, patch)
2020-11-13 15:48 PST, Matt Lewis
no flags Details | Formatted Diff | Diff
Patch (11.94 KB, patch)
2020-11-13 16:33 PST, Matt Lewis
no flags Details | Formatted Diff | Diff
Patch for landing (11.94 KB, patch)
2020-11-16 12:36 PST, Matt Lewis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2020-11-13 11:41:26 PST
Starting with just regular testers and builders, we are bringing up Big Sur now that it is fully released.
Comment 1 Radar WebKit Bug Importer 2020-11-13 11:41:35 PST
<rdar://problem/71379428>
Comment 2 Matt Lewis 2020-11-13 12:52:40 PST
Created attachment 414086 [details]
Patch
Comment 3 Matt Lewis 2020-11-13 14:46:48 PST
Created attachment 414095 [details]
Patch
Comment 4 Matt Lewis 2020-11-13 15:02:28 PST
Created attachment 414096 [details]
Patch
Comment 5 Matt Lewis 2020-11-13 15:48:25 PST
Created attachment 414100 [details]
Patch
Comment 6 Aakash Jain 2020-11-13 16:03:41 PST
Comment on attachment 414100 [details]
Patch

Patch looks fine. r- due to unit-tests failure. Try to run tests locally as well.
Comment 7 Matt Lewis 2020-11-13 16:33:14 PST
Created attachment 414105 [details]
Patch
Comment 8 Aakash Jain 2020-11-16 07:14:59 PST
Comment on attachment 414105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414105&action=review

> Tools/CISupport/build-webkit-org/config.json:130
> +                      "workernames": ["bot1020","bot1021"]

Nit: missing space after comma.

> Tools/CISupport/build-webkit-org/config.json:135
> +                      "workernames": ["bot1022","bot1023"]

Nit: missing space after comma.

> Tools/CISupport/build-webkit-org/config.json:150
> +                      "workernames": ["bot1026","bot1027"]

Nit: missing space after comma.
Comment 9 Matt Lewis 2020-11-16 12:36:45 PST
Created attachment 414270 [details]
Patch for landing
Comment 10 EWS 2020-11-16 13:27:33 PST
Committed r269874: <https://trac.webkit.org/changeset/269874>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414270 [details].
Comment 11 Aakash Jain 2020-11-17 07:26:48 PST
Comment on attachment 414270 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=414270&action=review

> Tools/CISupport/build-webkit-org/config.json:128
> +                      "platform": "mac-bigsur", "configuration": "release", "architectures": ["x86_64"],

architecture on builder and tester doesn't match. builder have: "["x86_64", "arm64"]", while tester have: ["x86_64"].

This mismatch is causing tester not to find the uploaded archive.
e.g.: in https://build.webkit.org/builders/Apple-BigSur-Release-Build/builds/3167/steps/transfer-to-s3/logs/stdio builder uploaded at:
https://s3-us-west-2.amazonaws.com/archives.webkit.org/mac-bigsur-x86_64 arm64-release/269887.zip

while in https://build.webkit.org/builders/Apple-BigSur-Release-WK1-Tests/builds/0/steps/download-built-product/logs/stdio tester is trying to download from: 
https://s3-us-west-2.amazonaws.com/archives.webkit.org/mac-bigsur-x86_64-release/269887.zip
Comment 12 Jonathan Bedard 2020-11-17 08:41:22 PST
(In reply to Aakash Jain from comment #11)
> Comment on attachment 414270 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414270&action=review
> 
> > Tools/CISupport/build-webkit-org/config.json:128
> > +                      "platform": "mac-bigsur", "configuration": "release", "architectures": ["x86_64"],
> 
> architecture on builder and tester doesn't match. builder have: "["x86_64",
> "arm64"]", while tester have: ["x86_64"].
> 
> This mismatch is causing tester not to find the uploaded archive.
> e.g.: in
> https://build.webkit.org/builders/Apple-BigSur-Release-Build/builds/3167/
> steps/transfer-to-s3/logs/stdio builder uploaded at:
> https://s3-us-west-2.amazonaws.com/archives.webkit.org/mac-bigsur-x86_64
> arm64-release/269887.zip
> 
> while in
> https://build.webkit.org/builders/Apple-BigSur-Release-WK1-Tests/builds/0/
> steps/download-built-product/logs/stdio tester is trying to download from: 
> https://s3-us-west-2.amazonaws.com/archives.webkit.org/mac-bigsur-x86_64-
> release/269887.zip

I guess the tester should declare that it wants universal binaries? That feels wrong though...results uploading knows the difference, so we aren't passing architecture through to run-webkit-tests.