Bug 218917 – Bring up Big Sur Builders and Testers

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Matt Lewis]

Starting with just regular testers and builders, we are bringing up Big Sur now that it is fully released.

[Radar WebKit Bug Importer]

<rdar://problem/71379428>

[Matt Lewis]

Created attachment 414086 [details]
Patch

[Matt Lewis]

Created attachment 414095 [details]
Patch

[Matt Lewis]

Created attachment 414096 [details]
Patch

[Matt Lewis]

Created attachment 414100 [details]
Patch

[Aakash Jain]

Comment on attachment 414100 [details]
Patch

Patch looks fine. r- due to unit-tests failure. Try to run tests locally as well.

[Matt Lewis]

Created attachment 414105 [details]
Patch

[Aakash Jain]

Comment on attachment 414105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414105&action=review

> Tools/CISupport/build-webkit-org/config.json:130
> +                      "workernames": ["bot1020","bot1021"]

Nit: missing space after comma.

> Tools/CISupport/build-webkit-org/config.json:135
> +                      "workernames": ["bot1022","bot1023"]

Nit: missing space after comma.

> Tools/CISupport/build-webkit-org/config.json:150
> +                      "workernames": ["bot1026","bot1027"]

Nit: missing space after comma.

[Matt Lewis]

Created attachment 414270 [details]
Patch for landing

[EWS]

Committed r269874: <https://trac.webkit.org/changeset/269874>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414270 [details].

[Aakash Jain]

Comment on attachment 414270 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=414270&action=review

> Tools/CISupport/build-webkit-org/config.json:128
> +                      "platform": "mac-bigsur", "configuration": "release", "architectures": ["x86_64"],

architecture on builder and tester doesn't match. builder have: "["x86_64", "arm64"]", while tester have: ["x86_64"].

This mismatch is causing tester not to find the uploaded archive.
e.g.: in https://build.webkit.org/builders/Apple-BigSur-Release-Build/builds/3167/steps/transfer-to-s3/logs/stdio builder uploaded at:
https://s3-us-west-2.amazonaws.com/archives.webkit.org/mac-bigsur-x86_64 arm64-release/269887.zip

while in https://build.webkit.org/builders/Apple-BigSur-Release-WK1-Tests/builds/0/steps/download-built-product/logs/stdio tester is trying to download from: 
https://s3-us-west-2.amazonaws.com/archives.webkit.org/mac-bigsur-x86_64-release/269887.zip

[Jonathan Bedard]

(In reply to Aakash Jain from comment #11)
> Comment on attachment 414270 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414270&action=review
> 
> > Tools/CISupport/build-webkit-org/config.json:128
> > +                      "platform": "mac-bigsur", "configuration": "release", "architectures": ["x86_64"],
> 
> architecture on builder and tester doesn't match. builder have: "["x86_64",
> "arm64"]", while tester have: ["x86_64"].
> 
> This mismatch is causing tester not to find the uploaded archive.
> e.g.: in
> https://build.webkit.org/builders/Apple-BigSur-Release-Build/builds/3167/
> steps/transfer-to-s3/logs/stdio builder uploaded at:
> https://s3-us-west-2.amazonaws.com/archives.webkit.org/mac-bigsur-x86_64
> arm64-release/269887.zip
> 
> while in
> https://build.webkit.org/builders/Apple-BigSur-Release-WK1-Tests/builds/0/
> steps/download-built-product/logs/stdio tester is trying to download from: 
> https://s3-us-west-2.amazonaws.com/archives.webkit.org/mac-bigsur-x86_64-
> release/269887.zip

I guess the tester should declare that it wants universal binaries? That feels wrong though...results uploading knows the difference, so we aren't passing architecture through to run-webkit-tests.