Bug 218916 - [clang-tidy] Run modernize-use-override through JSC
Summary: [clang-tidy] Run modernize-use-override through JSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-13 11:10 PST by Don Olmstead
Modified: 2020-11-14 02:31 PST (History)
13 users (show)

See Also:

Attachments
Patch (12.13 KB, patch)
2020-11-13 11:16 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (12.12 KB, patch)
2020-11-13 12:39 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-11-13 11:10:08 PST 
The modernizer fix isn't smart enough to use final for final classes so fix those up.
Comment 1 Don Olmstead 2020-11-13 11:16:18 PST 
Created attachment 414067 [details]
Patch
Comment 2 Don Olmstead 2020-11-13 12:39:12 PST 
Created attachment 414083 [details]
Patch
Comment 3 Yusuke Suzuki 2020-11-14 02:00:29 PST 
Comment on attachment 414083 [details]
Patch

r=me
Comment 4 EWS 2020-11-14 02:29:17 PST 
Committed r269814: <https://trac.webkit.org/changeset/269814>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414083 [details].
Comment 5 Radar WebKit Bug Importer 2020-11-14 02:31:33 PST 
<rdar://problem/71398957>