RESOLVED FIXED218915
[LFC][Integration] Use the physical size when setting the pre-computed width/height on ReplacedBox 
https://bugs.webkit.org/show_bug.cgi?id=218915
Summary [LFC][Integration] Use the physical size when setting the pre-computed width/...
alan
Reported 2020-11-13 10:36:32 PST
This is where the logical vs. physical flip happens for writing directions
Attachments
Patch (4.49 KB, patch)
2020-11-13 10:41 PST, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (4.62 KB, patch)
2020-11-13 10:59 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2020-11-13 10:41:37 PST
Created attachment 414061 [details] Patch
Antti Koivisto
Comment 2 2020-11-13 10:44:42 PST
Comment on attachment 414061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414061&action=review > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:126 > + updateReplacedDimensions(inlineBlock) Might be nicer to have a private shared function (updateReplacedOrInlineBlockDimensions or similar)
alan
Comment 3 2020-11-13 10:48:08 PST
(In reply to Antti Koivisto from comment #2) > Comment on attachment 414061 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414061&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:126 > > + updateReplacedDimensions(inlineBlock) > > Might be nicer to have a private shared function > (updateReplacedOrInlineBlockDimensions or similar) good point!
alan
Comment 4 2020-11-13 10:59:27 PST
Created attachment 414065 [details] Patch
EWS
Comment 5 2020-11-14 09:39:00 PST
Committed r269818: <https://trac.webkit.org/changeset/269818> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414065 [details].
Radar WebKit Bug Importer
Comment 6 2020-11-14 09:39:18 PST
<rdar://problem/71402371>
Note You need to log in before you can comment on or make changes to this bug.