Bug 218915 - [LFC][Integration] Use the physical size when setting the pre-computed width/height on ReplacedBox
Summary: [LFC][Integration] Use the physical size when setting the pre-computed width/...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-13 10:36 PST by zalan
Modified: 2020-11-14 09:39 PST (History)
11 users (show)

See Also:

Attachments
Patch (4.49 KB, patch)
2020-11-13 10:41 PST, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.62 KB, patch)
2020-11-13 10:59 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-11-13 10:36:32 PST 
This is where the logical vs. physical flip happens for writing directions
Comment 1 zalan 2020-11-13 10:41:37 PST 
Created attachment 414061 [details]
Patch
Comment 2 Antti Koivisto 2020-11-13 10:44:42 PST 
Comment on attachment 414061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414061&action=review

> Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:126
> +    updateReplacedDimensions(inlineBlock)

Might be nicer to have a private shared function (updateReplacedOrInlineBlockDimensions or similar)
Comment 3 zalan 2020-11-13 10:48:08 PST 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 414061 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414061&action=review
> 
> > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:126
> > +    updateReplacedDimensions(inlineBlock)
> 
> Might be nicer to have a private shared function
> (updateReplacedOrInlineBlockDimensions or similar)
good point!
Comment 4 zalan 2020-11-13 10:59:27 PST 
Created attachment 414065 [details]
Patch
Comment 5 EWS 2020-11-14 09:39:00 PST 
Committed r269818: <https://trac.webkit.org/changeset/269818>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414065 [details].
Comment 6 Radar WebKit Bug Importer 2020-11-14 09:39:18 PST 
<rdar://problem/71402371>