218908 – [Mac] Create a MediaToolbox format reader plug-in for WebM

RESOLVED FIXED 218908

[Mac] Create a MediaToolbox format reader plug-in for WebM

https://bugs.webkit.org/show_bug.cgi?id=218908

Summary [Mac] Create a MediaToolbox format reader plug-in for WebM

Andy Estes

Reported 2020-11-13 09:04:03 PST

[Mac] Create a MediaToolbox format reader plug-in for WebM

Attachments
WIP (113.81 KB, patch) 2020-11-15 14:48 PST, Andy Estes	no flags	Details Formatted Diff Diff
WIP (113.81 KB, patch) 2020-11-17 13:02 PST, Eric Carlson	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP (113.88 KB, patch) 2020-11-17 13:30 PST, Eric Carlson	no flags	Details Formatted Diff Diff
More WIP: add a runtime flag (117.86 KB, patch) 2020-11-17 15:34 PST, Eric Carlson	no flags	Details Formatted Diff Diff
More WIP: SampleCursor improvements (125.41 KB, patch) 2020-12-01 13:42 PST, Andy Estes	no flags	Details Formatted Diff Diff
Another WIP (204.42 KB, patch) 2020-12-08 16:13 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Another WIP (204.98 KB, patch) 2020-12-08 17:35 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Another WIP (205.01 KB, patch) 2020-12-09 00:12 PST, Eric Carlson	ews-feeder: commit-queue-	Details Formatted Diff Diff
More WIP: Implement SampleCursor::copySampleLocation (218.41 KB, patch) 2020-12-09 03:08 PST, Andy Estes	no flags	Details Formatted Diff Diff
More WIP: cleanup and refactor SourceBufferParserWebM (223.61 KB, patch) 2020-12-09 17:31 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Part 1: Install a format reader plug-in in WebKit.framework/PlugIns (28.33 KB, patch) 2020-12-09 17:34 PST, Andy Estes	eric.carlson: review+	Details Formatted Diff Diff
Part 1: Create a format reader plug-in for WebM (28.07 KB, patch) 2020-12-10 17:19 PST, Andy Estes	no flags	Details Formatted Diff Diff
Part 2: Register the format reader plug-in for WebM content types (16.48 KB, patch) 2020-12-10 17:37 PST, Andy Estes	eric.carlson: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
Part 2: Register the format reader plug-in for WebM content types (16.52 KB, patch) 2020-12-10 17:46 PST, Andy Estes	no flags	Details Formatted Diff Diff
Part 2: Register the format reader plug-in for WebM content types (17.32 KB, patch) 2020-12-10 18:32 PST, Andy Estes	no flags	Details Formatted Diff Diff
Part 2: Register the format reader plug-in for WebM content types (17.19 KB, patch) 2020-12-10 18:36 PST, Andy Estes	no flags	Details Formatted Diff Diff
Part 2: Register the format reader plug-in for WebM content types (16.95 KB, patch) 2020-12-10 19:39 PST, Andy Estes	no flags	Details Formatted Diff Diff
Part 3: Abstract SourceBufferParser segments (9.72 KB, patch) 2020-12-10 23:18 PST, Andy Estes	no flags	Details Formatted Diff Diff
Part 2: Register the format reader plug-in for WebM content types (16.90 KB, patch) 2020-12-11 15:34 PST, Andy Estes	ews-feeder: commit-queue-	Details Formatted Diff Diff
Part 3: Abstract SourceBufferParser segments (9.71 KB, patch) 2020-12-11 15:38 PST, Andy Estes	aestes: commit-queue-	Details Formatted Diff Diff
Part 3: Abstract SourceBufferParser segments (9.72 KB, patch) 2020-12-11 15:39 PST, Andy Estes	no flags	Details Formatted Diff Diff
Part 4: Implement and test the format reader (107.45 KB, patch) 2020-12-11 20:32 PST, Andy Estes	no flags	Details Formatted Diff Diff
Part 4: Implement and test the format reader (108.21 KB, patch) 2020-12-11 22:46 PST, Andy Estes	no flags	Details Formatted Diff Diff
Part 4: Implement and test the format reader (108.75 KB, patch) 2020-12-12 06:47 PST, Andy Estes	no flags	Details Formatted Diff Diff
Part 4: Implement and test the format reader (111.10 KB, patch) 2020-12-12 09:21 PST, Andy Estes	no flags	Details Formatted Diff Diff
Part 4: Implement and test the format reader (119.21 KB, patch) 2020-12-12 11:32 PST, Andy Estes	ews-feeder: commit-queue-	Details Formatted Diff Diff
Part 4: Implement and test the format reader (119.70 KB, patch) 2020-12-12 11:54 PST, Andy Estes	ews-feeder: commit-queue-	Details Formatted Diff Diff
Part 4: Implement and test the format reader (119.63 KB, patch) 2020-12-12 12:02 PST, Andy Estes	no flags	Details Formatted Diff Diff
Part 4: Implement and test the format reader (118.17 KB, patch) 2020-12-12 13:19 PST, Andy Estes	no flags	Details Formatted Diff Diff
Patch for landing (131.08 KB, patch) 2020-12-12 21:48 PST, Andy Estes	no flags	Details Formatted Diff Diff
Patch for landing (131.08 KB, patch) 2020-12-13 10:50 PST, Andy Estes	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (131.07 KB, patch) 2020-12-13 13:36 PST, Andy Estes	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (138.31 KB, patch) 2020-12-13 16:31 PST, Andy Estes	no flags	Details Formatted Diff Diff
Patch for landing (140.56 KB, patch) 2020-12-13 18:17 PST, Andy Estes	no flags	Details Formatted Diff Diff
Patch for landing (141.15 KB, patch) 2020-12-13 18:44 PST, Andy Estes	no flags	Details Formatted Diff Diff
Show Obsolete (32) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2020-11-13 09:04:35 PST Comment hidden (obsolete)

rdar://58128802

Andy Estes

Comment 2 2020-11-13 09:12:21 PST

rdar://71373264

Andy Estes

Comment 3 2020-11-15 14:48:08 PST Comment hidden (obsolete)

Created attachment 414179 [details] WIP

Andy Estes

Comment 4 2020-11-15 14:52:09 PST Comment hidden (obsolete)

Work in(In reply to Andy Estes from comment #3) > Created attachment 414179 [details] > WIP Still plenty of cleanup left to do, notably: 1. The plug-in should move from WebCore to WebKit since it must link the WebKit umbrella framework on Mac. 2. The WebContent process needs to register the plug-in at runtime (although this is testable now in a stand-alone test executable). 3. Needs a runtime flag.

Eric Carlson

Comment 5 2020-11-17 13:02:21 PST Comment hidden (obsolete)

Created attachment 414376 [details] WIP

Eric Carlson

Comment 6 2020-11-17 13:30:56 PST Comment hidden (obsolete)

Created attachment 414381 [details] WIP

Eric Carlson

Comment 7 2020-11-17 15:34:09 PST Comment hidden (obsolete)

Created attachment 414391 [details] More WIP: add a runtime flag

Andy Estes

Comment 8 2020-12-01 13:42:46 PST Comment hidden (obsolete)

Created attachment 415157 [details] More WIP: SampleCursor improvements

Eric Carlson

Comment 9 2020-12-08 16:13:34 PST Comment hidden (obsolete)

Created attachment 415688 [details] Another WIP

Eric Carlson

Comment 10 2020-12-08 17:35:56 PST Comment hidden (obsolete)

Created attachment 415695 [details] Another WIP

Eric Carlson

Comment 11 2020-12-09 00:12:31 PST Comment hidden (obsolete)

Created attachment 415725 [details] Another WIP

Andy Estes

Comment 12 2020-12-09 03:08:05 PST Comment hidden (obsolete)

Created attachment 415734 [details] More WIP: Implement SampleCursor::copySampleLocation

Eric Carlson

Comment 13 2020-12-09 17:31:14 PST Comment hidden (obsolete)

Created attachment 415814 [details] More WIP: cleanup and refactor SourceBufferParserWebM

Andy Estes

Comment 14 2020-12-09 17:34:55 PST Comment hidden (obsolete)

Created attachment 415815 [details] Part 1: Install a format reader plug-in in WebKit.framework/PlugIns

Andy Estes

Comment 15 2020-12-10 17:19:53 PST Comment hidden (obsolete)

Created attachment 415949 [details] Part 1: Create a format reader plug-in for WebM

Andy Estes

Comment 16 2020-12-10 17:37:16 PST Comment hidden (obsolete)

Created attachment 415952 [details] Part 2: Register the format reader plug-in for WebM content types

Andy Estes

Comment 17 2020-12-10 17:46:41 PST Comment hidden (obsolete)

Created attachment 415953 [details] Part 2: Register the format reader plug-in for WebM content types

Andy Estes

Comment 18 2020-12-10 18:32:09 PST Comment hidden (obsolete)

Created attachment 415956 [details] Part 2: Register the format reader plug-in for WebM content types

Andy Estes

Comment 19 2020-12-10 18:36:20 PST Comment hidden (obsolete)

Created attachment 415957 [details] Part 2: Register the format reader plug-in for WebM content types

Andy Estes

Comment 20 2020-12-10 19:39:44 PST Comment hidden (obsolete)

Created attachment 415961 [details] Part 2: Register the format reader plug-in for WebM content types

EWS

Comment 21 2020-12-10 21:21:51 PST

Committed r270666: <https://trac.webkit.org/changeset/270666> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415949 [details].

Andy Estes

Comment 22 2020-12-10 23:18:37 PST

Reopening to attach new patch.

Andy Estes

Comment 23 2020-12-10 23:18:38 PST Comment hidden (obsolete)

Created attachment 415972 [details] Part 3: Abstract SourceBufferParser segments

EWS

Comment 24 2020-12-11 15:19:33 PST Comment hidden (obsolete)

Patch 415961 does not build

Andy Estes

Comment 25 2020-12-11 15:34:05 PST Comment hidden (obsolete)

Created attachment 416054 [details] Part 2: Register the format reader plug-in for WebM content types

Andy Estes

Comment 26 2020-12-11 15:38:33 PST Comment hidden (obsolete)

Created attachment 416056 [details] Part 3: Abstract SourceBufferParser segments

EWS

Comment 27 2020-12-11 15:39:30 PST Comment hidden (obsolete)

/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Andy Estes

Comment 28 2020-12-11 15:39:47 PST Comment hidden (obsolete)

Created attachment 416057 [details] Part 3: Abstract SourceBufferParser segments

EWS

Comment 29 2020-12-11 16:08:13 PST

Committed r270717: <https://trac.webkit.org/changeset/270717> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416057 [details].

Andy Estes

Comment 30 2020-12-11 17:44:01 PST

Reopening to attach new patch.

EWS

Comment 31 2020-12-11 18:05:47 PST Comment hidden (obsolete)

Found 4 new test failures: imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType.html, imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html, imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/resize-during-playback.html, media/media-can-play-webm.html

Andy Estes

Comment 32 2020-12-11 20:32:24 PST Comment hidden (obsolete)

Created attachment 416085 [details] Part 4: Implement and test the format reader

Andy Estes

Comment 33 2020-12-11 22:46:09 PST Comment hidden (obsolete)

Created attachment 416094 [details] Part 4: Implement and test the format reader

Andy Estes

Comment 34 2020-12-12 06:47:40 PST Comment hidden (obsolete)

Created attachment 416095 [details] Part 4: Implement and test the format reader

Andy Estes

Comment 35 2020-12-12 09:21:42 PST Comment hidden (obsolete)

Created attachment 416098 [details] Part 4: Implement and test the format reader

Andy Estes

Comment 36 2020-12-12 11:32:08 PST Comment hidden (obsolete)

Created attachment 416102 [details] Part 4: Implement and test the format reader

Andy Estes

Comment 37 2020-12-12 11:54:05 PST Comment hidden (obsolete)

Created attachment 416103 [details] Part 4: Implement and test the format reader

Andy Estes

Comment 38 2020-12-12 12:02:04 PST Comment hidden (obsolete)

Created attachment 416104 [details] Part 4: Implement and test the format reader

Andy Estes

Comment 39 2020-12-12 13:19:01 PST Comment hidden (obsolete)

Created attachment 416106 [details] Part 4: Implement and test the format reader

Andy Estes

Comment 40 2020-12-12 21:48:05 PST Comment hidden (obsolete)

Created attachment 416113 [details] Patch for landing

Andy Estes

Comment 41 2020-12-13 10:50:47 PST Comment hidden (obsolete)

Created attachment 416123 [details] Patch for landing

Andy Estes

Comment 42 2020-12-13 13:36:16 PST Comment hidden (obsolete)

Created attachment 416125 [details] Patch for landing

Andy Estes

Comment 43 2020-12-13 16:31:48 PST Comment hidden (obsolete)

Created attachment 416128 [details] Patch for landing

Andy Estes

Comment 44 2020-12-13 18:17:29 PST Comment hidden (obsolete)

Created attachment 416130 [details] Patch for landing

Andy Estes

Comment 45 2020-12-13 18:44:28 PST

Created attachment 416131 [details] Patch for landing

EWS

Comment 46 2020-12-13 19:39:27 PST

Committed r270758: <https://trac.webkit.org/changeset/270758> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416131 [details].

Andy Estes

Comment 47 2020-12-13 20:40:22 PST

Fixed the build in r270760: <https://trac.webkit.org/changeset/270760>

Andy Estes

Comment 48 2020-12-13 21:20:28 PST

Fixed the build in r270761: <https://trac.webkit.org/changeset/270761>

Truitt Savell

Comment 49 2020-12-22 14:21:54 PST

This caused an Internal testing failure tracked in: rdar://72600426

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Andy Estes

Reported

2020-11-13 09:04 PST

Modified

2021-06-24 17:45 PDT History

CC List

19 users Show

URL

Keywords InRadar

Depends on

227382

Blocks

Dependencies

tree graph