Bug 218902 – Add support for discrete animations of many CSS properties

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

Add support for discrete animations of many CSS properties

[Antoine Quint]

Namely: -webkit-backface-visibility, -webkit-box-decoration-break, -webkit-hyphens, -webkit-initial-letter, -webkit-print-color-adjust, -webkit-ruby-position, -webkit-text-emphasis-color, -webkit-text-emphasis-position, border-bottom-style, border-collapse, border-left-style, border-right-style, border-top-style, box-sizing, caption-side, clear, column-fill, column-rule-style, column-rule-style, cursor, empty-cells, flex-direction, flex-wrap, float, grid-auto-columns, grid-auto-flow, grid-auto-rows, grid-column-end, grid-column-start, grid-row-end, grid-row-start, image-orientation, isolation, justify-content, justify-items, justify-self, list-style-position, list-style-type, mix-blend-mode, object-fit, outline-style, overflow-wrap, overflow-x, overflow-y, page-break-after, page-break-before, page-break-inside, paint-order, pointer-events, position, resize, scroll-behavior, table-layout, text-align, text-decoration-color, text-decoration-line, text-decoration-style, text-overflow, text-transform, touch-action, transform-box, transform-style, white-space, word-break.

[Antoine Quint]

Created attachment 414044 [details]
Patch

[Antti Koivisto]

Comment on attachment 414044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414044&action=review

> Source/WebCore/animation/CSSPropertyAnimation.cpp:1917
>          new DiscretePropertyWrapper<const StyleContentAlignmentData&>(CSSPropertyAlignContent, &RenderStyle::alignContent, &RenderStyle::setAlignContent),
>          new DiscretePropertyWrapper<const StyleSelfAlignmentData&>(CSSPropertyAlignItems, &RenderStyle::alignItems, &RenderStyle::setAlignItems),
>          new DiscretePropertyWrapper<const StyleSelfAlignmentData&>(CSSPropertyAlignSelf, &RenderStyle::alignSelf, &RenderStyle::setAlignSelf),
> +        new DiscretePropertyWrapper<BackfaceVisibility>(CSSPropertyWebkitBackfaceVisibility, &RenderStyle::backfaceVisibility, &RenderStyle::setBackfaceVisibility),

Maybe this stuff should be generated from CSSProperties.json?

[Antoine Quint]

Actually, scroll-behavior will be for another bug.

[Antoine Quint]

Created attachment 414077 [details]
Patch

[Antoine Quint]

Committed r269812: <https://trac.webkit.org/changeset/269812>

[Radar WebKit Bug Importer]

<rdar://problem/71398181>

[Antoine Quint]

*** Bug 219564 has been marked as a duplicate of this bug. ***