Support more properties on ::marker

[Antoine Quint]

Support more properties on ::marker

[Antoine Quint]

Created attachment 414020 [details]
Patch

[Antti Koivisto]

Comment on attachment 414020 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414020&action=review

> Source/WebCore/css/html.css:305
>  ::marker {

You could add a comment here saying that the ::before/::after are handled by computeMarkerStyle.

> Source/WebCore/rendering/RenderListItem.cpp:75
>      RenderStyle parentStyle = RenderStyle::clone(style());
>      auto fontDescription = style().fontDescription();
> -    fontDescription.setVariantNumericSpacing(FontVariantNumericSpacing::TabularNumbers);
> +    if (is<PseudoElement>(element()))
> +        fontDescription.setVariantNumericSpacing(FontVariantNumericSpacing::TabularNumbers);
>      parentStyle.setFontDescription(WTFMove(fontDescription));
>      parentStyle.fontCascade().update(&document().fontSelector());
>      if (auto markerStyle = getCachedPseudoStyle(PseudoId::Marker, &parentStyle))

This seems overly hackish. If I understand correctly this function should have two branches. 

1) The regular one that just does getCachedPseudoStyle(PseudoId::Marker, &style()) and nothing else a
2) A hack branch for is<PseudoElement> case where it initializes all of ::marker UA style (including unicode-bidi and white-space). It doesn't need to call getCachedPseudoStyle since it won't work.

[Antoine Quint]

Created attachment 414033 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/71368343>

[Antoine Quint]

Committed r269774: <https://trac.webkit.org/changeset/269774>