[WASM-References] Remove subtyping rule for externref and funcref
Created attachment 414003 [details] Patch
Comment on attachment 414003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414003&action=review The design looks good. Can you check JSC test failure? > Source/JavaScriptCore/wasm/WasmFormat.h:81 > +inline bool isSubtype(Type sub, Type parent) { return sub == parent; } Let's remove this function since `sub == parent` is the same type.
Created attachment 414206 [details] Patch
Comment on attachment 414003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414003&action=review >> Source/JavaScriptCore/wasm/WasmFormat.h:81 >> +inline bool isSubtype(Type sub, Type parent) { return sub == parent; } > > Let's remove this function since `sub == parent` is the same type. Thanks! Removed this.
Created attachment 414308 [details] Patch
Created attachment 414312 [details] Patch
Created attachment 414319 [details] Patch
Comment on attachment 414319 [details] Patch r=me
Committed r270015: <https://trac.webkit.org/changeset/270015> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414319 [details].
<rdar://problem/71569391>