RESOLVED FIXED 218885
[WASM-References] Remove subtyping rule for externref and funcref 
https://bugs.webkit.org/show_bug.cgi?id=218885
Summary [WASM-References] Remove subtyping rule for externref and funcref
Dmitry
Reported 2020-11-12 21:16:17 PST
[WASM-References] Remove subtyping rule for externref and funcref
Attachments
Patch (10.35 KB, patch)
2020-11-12 21:21 PST, Dmitry 		no flags
DetailsFormatted DiffDiff
Patch (31.23 KB, patch)
2020-11-16 02:09 PST, Dmitry 		no flags
DetailsFormatted DiffDiff
Patch (31.97 KB, patch)
2020-11-16 22:29 PST, Dmitry 		no flags
DetailsFormatted DiffDiff
Patch (32.79 KB, patch)
2020-11-16 23:30 PST, Dmitry 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (32.93 KB, patch)
2020-11-17 01:41 PST, Dmitry 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Dmitry
Comment 1 2020-11-12 21:21:13 PST
Created attachment 414003 [details] Patch
Yusuke Suzuki
Comment 2 2020-11-14 02:03:00 PST
Comment on attachment 414003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414003&action=review The design looks good. Can you check JSC test failure? > Source/JavaScriptCore/wasm/WasmFormat.h:81 > +inline bool isSubtype(Type sub, Type parent) { return sub == parent; } Let's remove this function since `sub == parent` is the same type.
Dmitry
Comment 3 2020-11-16 02:09:13 PST
Created attachment 414206 [details] Patch
Dmitry
Comment 4 2020-11-16 02:10:42 PST
Comment on attachment 414003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414003&action=review >> Source/JavaScriptCore/wasm/WasmFormat.h:81 >> +inline bool isSubtype(Type sub, Type parent) { return sub == parent; } > > Let's remove this function since `sub == parent` is the same type. Thanks! Removed this.
Dmitry
Comment 5 2020-11-16 22:29:38 PST
Created attachment 414308 [details] Patch
Dmitry
Comment 6 2020-11-16 23:30:02 PST
Created attachment 414312 [details] Patch
Dmitry
Comment 7 2020-11-17 01:41:14 PST
Created attachment 414319 [details] Patch
Yusuke Suzuki
Comment 8 2020-11-18 20:07:03 PST
Comment on attachment 414319 [details] Patch r=me
EWS
Comment 9 2020-11-18 20:11:40 PST
Committed r270015: <https://trac.webkit.org/changeset/270015> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414319 [details].
Radar WebKit Bug Importer
Comment 10 2020-11-18 20:12:18 PST
<rdar://problem/71569391>
Note You need to log in before you can comment on or make changes to this bug.