Bug 218843 - [GPU Process] Implement DisplayList::ClipToImageBuffer item
Summary: [GPU Process] Implement DisplayList::ClipToImageBuffer item
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 217342
  Show dependency tree / graph
 
Reported: 2020-11-11 21:26 PST by Said Abou-Hallawa
Modified: 2020-11-12 01:10 PST (History)
5 users (show)

See Also:

Attachments
Patch (28.75 KB, patch)
2020-11-11 21:28 PST, Said Abou-Hallawa 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (28.73 KB, patch)
2020-11-11 21:36 PST, Said Abou-Hallawa 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (28.74 KB, patch)
2020-11-11 21:46 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (28.69 KB, patch)
2020-11-11 23:33 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2020-11-11 21:26:00 PST 
This is very similar to the DisplayList::DrawImageBuffer item. All we need is to record the renderingResourceIdentifier of the ImageBuffer. At replaying time, the renderingResourceIdentifier of the ClipToImageBuffer will be resolved to an ImageBuffer. The actual clipping will be moved to an new function named ImageBuffer::clipToMask().
Comment 1 Said Abou-Hallawa 2020-11-11 21:28:43 PST 
Created attachment 413908 [details]
Patch
Comment 2 Said Abou-Hallawa 2020-11-11 21:36:37 PST 
Created attachment 413909 [details]
Patch
Comment 3 Said Abou-Hallawa 2020-11-11 21:46:51 PST 
Created attachment 413910 [details]
Patch
Comment 4 Said Abou-Hallawa 2020-11-11 23:33:03 PST 
Created attachment 413915 [details]
Patch
Comment 5 EWS 2020-11-12 01:09:22 PST 
Committed r269724: <https://trac.webkit.org/changeset/269724>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413915 [details].
Comment 6 Radar WebKit Bug Importer 2020-11-12 01:10:20 PST 
<rdar://problem/71318029>