Bug 218820 - [iOS] IOKit sandbox violation when enabling all GPU runtime flags
Summary: [iOS] IOKit sandbox violation when enabling all GPU runtime flags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-11 13:14 PST by Per Arne Vollan
Modified: 2020-11-12 14:12 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.76 KB, patch)
2020-11-11 13:38 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (3.08 KB, patch)
2020-11-11 13:40 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-11-11 13:14:56 PST 
When enabling all GPU runtime flags on iOS, there is an iokit-open sandbox violation in the WebContent process.
Comment 1 Radar WebKit Bug Importer 2020-11-11 13:16:18 PST 
<rdar://problem/71296116>
Comment 2 Per Arne Vollan 2020-11-11 13:38:01 PST 
Created attachment 413859 [details]
Patch
Comment 3 Per Arne Vollan 2020-11-11 13:40:07 PST 
Created attachment 413860 [details]
Patch
Comment 4 Brent Fulgham 2020-11-12 14:02:45 PST 
Comment on attachment 413860 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413860&action=review

r=me

> Source/WebKit/ChangeLog:9
> +        When enabling all GPU runtime flags on iOS, there is an iokit-open sandbox violation for the IOKit class AGXDeviceUserClient

Is it a violation? Or just a violation report indicating that the access was allowed? I suspect it's the latter (i.e., we always allowed it, but we were logging in a case where we expected the access).
Comment 5 Per Arne Vollan 2020-11-12 14:04:54 PST 
(In reply to Brent Fulgham from comment #4)
> Comment on attachment 413860 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413860&action=review
> 
> r=me
> 
> > Source/WebKit/ChangeLog:9
> > +        When enabling all GPU runtime flags on iOS, there is an iokit-open sandbox violation for the IOKit class AGXDeviceUserClient
> 
> Is it a violation? Or just a violation report indicating that the access was
> allowed? I suspect it's the latter (i.e., we always allowed it, but we were
> logging in a case where we expected the access).

This was actually an IOKit open violation, which caused a crash.

Thanks for reviewing!
Comment 6 EWS 2020-11-12 14:12:45 PST 
Committed r269751: <https://trac.webkit.org/changeset/269751>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413860 [details].