Bug 21882 - [CAIRO] Canvas radial gradient broken
Summary: [CAIRO] Canvas radial gradient broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL: https://developer.mozilla.org/samples...
Keywords: Cairo
Depends on:
Blocks:
 
Reported: 2008-10-24 23:03 PDT by Dirk Schulze
Modified: 2008-11-12 23:31 PST (History)
0 users

See Also:

Attachments
Fixed radialGradient (1.19 KB, patch)
2008-10-25 01:01 PDT, Dirk Schulze 		darin: review+
Details | Formatted Diff | Diff
LayoutTest (2.92 KB, patch)
2008-10-31 12:11 PDT, Dirk Schulze 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2008-10-24 23:03:57 PDT 
The inner circle of a radial gradient is always white but shouldn't be.
Comment 1 Dirk Schulze 2008-10-25 00:35:58 PDT 
fixed in one of the last revisions.
Comment 2 Dirk Schulze 2008-10-25 00:55:25 PDT 
Oops! Still unfixed.
Comment 3 Dirk Schulze 2008-10-25 01:01:38 PDT 
Created attachment 24672 [details]
Fixed radialGradient

I removed CAIRO_EXTEND_NONE in applySpreadMethod. We don't need it neither in SVG nor Canvas or CSS. And we don't need to define a default at all.
Comment 4 Darin Adler 2008-10-31 10:23:36 PDT 
Comment on attachment 24672 [details]
Fixed radialGradient

This is the kind of patch I'd normally turn down without a regression test. Does the GTK port currently work with text-only regression tests? If so, it would be really easy to write one for this bug that uses a canvas and reads out the expected correct pixel vale, and I'd like to see it.

r=me in any case
Comment 5 Dirk Schulze 2008-10-31 12:11:55 PDT 
Created attachment 24806 [details]
LayoutTest

A LayoutTest to check the behavior.
Comment 6 Darin Adler 2008-10-31 12:20:26 PDT 
Comment on attachment 24806 [details]
LayoutTest

Nice!

r=me
Comment 7 Dirk Schulze 2008-11-11 12:14:27 PST 
landed in r38302