Bug 218814 - Define USE(LEGACY_CFNETWORK_DOWNLOADS)
Summary: Define USE(LEGACY_CFNETWORK_DOWNLOADS)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-11 11:47 PST by Alex Christensen
Modified: 2020-11-11 13:12 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.00 KB, patch)
2020-11-11 11:49 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (2.95 KB, patch)
2020-11-11 12:06 PST, Alex Christensen 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-11-11 11:47:43 PST 
Define HAVE(MOJAVE_CFNETWORK)
Comment 1 Alex Christensen 2020-11-11 11:49:28 PST 
Created attachment 413845 [details]
Patch
Comment 2 Geoffrey Garen 2020-11-11 12:01:45 PST 
Comment on attachment 413845 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413845&action=review

> Source/WTF/wtf/PlatformHave.h:423
> +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101500
> +#define HAVE_MOJAVE_CFNETWORK 1
> +#endif

The new name here is still a statement about an OS version ("Mojave"), so not much has changed. Also, we usually use "HAVE(X)" to mean that a feature is present, not that a bug must be worked around.

This is a tricky case. Our existing macro patterns don't fit super well.

I think a better fit might be one of:

ENABLE(CFNETWORK_DOWNLOAD_WORKAROUNDS)
USE(LEGACY_CFNETWORK_DOWNLOADS)

or inverted:

HAVE(MODERN_CFNETWORK_DOWNLOADS)
Comment 3 Alex Christensen 2020-11-11 12:06:28 PST 
Created attachment 413848 [details]
Patch
Comment 4 Geoffrey Garen 2020-11-11 13:03:28 PST 
Comment on attachment 413848 [details]
Patch

r=me
Comment 5 Alex Christensen 2020-11-11 13:10:16 PST 
http://trac.webkit.org/r269700
Comment 6 Radar WebKit Bug Importer 2020-11-11 13:12:36 PST 
<rdar://problem/71296010>