Bug 218810 - Use _CFURLConnectionSetFrameworkStubs instead of DYLD_INTERPOSE on Intel Macs
Summary: Use _CFURLConnectionSetFrameworkStubs instead of DYLD_INTERPOSE on Intel Macs
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Keywords: InRadar
Depends on:
Reported: 2020-11-11 10:20 PST by Alex Christensen
Modified: 2020-11-12 11:14 PST (History)
2 users (show)

See Also:

Patch (2.66 KB, patch)
2020-11-11 10:24 PST, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-11-11 10:20:36 PST
Use _CFURLConnectionSetFrameworkStubs instead of DYLD_INTERPOSE on Intel Macs
Comment 1 Alex Christensen 2020-11-11 10:24:54 PST
Created attachment 413837 [details]
Comment 2 Geoffrey Garen 2020-11-11 11:50:23 PST
Comment on attachment 413837 [details]

Comment 3 EWS 2020-11-11 12:15:29 PST
Committed r269697: <https://trac.webkit.org/changeset/269697>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413837 [details].
Comment 4 Radar WebKit Bug Importer 2020-11-11 12:16:24 PST
Comment 5 Alexey Proskuryakov 2020-11-11 16:43:55 PST
And if this breaks something, it's good to have identical behavior between Intel and Apple Silicon.

I think that initially, we couldn't use CFNetworks shims on macOS because of in-process CoreMedia resource loading, but that should not be a problem any more.

But isn't there a lot more icky code that can be removed now?
Comment 6 Alex Christensen 2020-11-12 09:57:57 PST
There is, but I chose to keep it to make it easier to revert if needed.  Now that I think about it, we should just remove it and revert that too if needed.
Comment 7 Alex Christensen 2020-11-12 11:14:28 PST