RESOLVED FIXED 218810
Use _CFURLConnectionSetFrameworkStubs instead of DYLD_INTERPOSE on Intel Macs 
https://bugs.webkit.org/show_bug.cgi?id=218810
Summary Use _CFURLConnectionSetFrameworkStubs instead of DYLD_INTERPOSE on Intel Macs
Alex Christensen
Reported 2020-11-11 10:20:36 PST
Use _CFURLConnectionSetFrameworkStubs instead of DYLD_INTERPOSE on Intel Macs
Attachments
Patch (2.66 KB, patch)
2020-11-11 10:24 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-11-11 10:24:54 PST
Created attachment 413837 [details] Patch
Geoffrey Garen
Comment 2 2020-11-11 11:50:23 PST
Comment on attachment 413837 [details] Patch r=me
EWS
Comment 3 2020-11-11 12:15:29 PST
Committed r269697: <https://trac.webkit.org/changeset/269697> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413837 [details].
Radar WebKit Bug Importer
Comment 4 2020-11-11 12:16:24 PST
<rdar://problem/71293705>
Alexey Proskuryakov
Comment 5 2020-11-11 16:43:55 PST
And if this breaks something, it's good to have identical behavior between Intel and Apple Silicon. I think that initially, we couldn't use CFNetworks shims on macOS because of in-process CoreMedia resource loading, but that should not be a problem any more. But isn't there a lot more icky code that can be removed now?
Alex Christensen
Comment 6 2020-11-12 09:57:57 PST
There is, but I chose to keep it to make it easier to revert if needed. Now that I think about it, we should just remove it and revert that too if needed.
Alex Christensen
Comment 7 2020-11-12 11:14:28 PST
https://bugs.webkit.org/show_bug.cgi?id=218862
Note You need to log in before you can comment on or make changes to this bug.