Bug 218808 – [iOS][FCR] Add new look for checkboxes

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Aditya Keerthi]

...

[Aditya Keerthi]

<rdar://problem/71286037>

[Aditya Keerthi]

Created attachment 413831 [details]
Patch

[Wenson Hsieh]

Comment on attachment 413831 [details]
Patch

The change itself seems fine, but I think it would be nice to add a runtime-enabled setting for this, so that it can be tested in some capacity, in the future.

[Sam Weinig]

Comment on attachment 413831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413831&action=review

> Source/WebCore/css/html.css:775
> +input[type="radio"] {
> +    margin: 3px 2px;

There are other separated out input[type="radio"] and input[type="checkbox"] lower down in the file. Now that these aren't for both anymore, can we just merge these with the ones lower down?

[Aditya Keerthi]

Created attachment 414254 [details]
Patch

[Aditya Keerthi]

(In reply to Sam Weinig from comment #4)
> Comment on attachment 413831 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413831&action=review
> 
> > Source/WebCore/css/html.css:775
> > +input[type="radio"] {
> > +    margin: 3px 2px;
> 
> There are other separated out input[type="radio"] and input[type="checkbox"]
> lower down in the file. Now that these aren't for both anymore, can we just
> merge these with the ones lower down?

These changes are now made in a separate stylesheet, so that this feature can be turned on/off at runtime.

[EWS]

Committed r269913: <https://trac.webkit.org/changeset/269913>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414254 [details].