Bug 21880 - "files" string for multifile uploads needs to be localized
Summary: "files" string for multifile uploads needs to be localized
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2008-10-24 21:53 PDT by Sam Weinig
Modified: 2008-10-28 16:36 PDT (History)
2 users (show)

See Also:

patch (38.02 KB, patch)
2008-10-28 13:25 PDT, Adele Peterson
sullivan: review-
Details | Formatted Diff | Diff
updated patch (9.73 KB, patch)
2008-10-28 16:15 PDT, Adele Peterson
sullivan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2008-10-24 21:53:58 PDT
The string we use when you select multiple files for upload needs locatlization
Comment 1 Adele Peterson 2008-10-28 13:25:36 PDT
Created attachment 24726 [details]

This also includes changes to update-webkit-localizable-strings since the script wasn't working with the Mac platform directory structure
Comment 2 Sam Weinig 2008-10-28 13:32:02 PDT
Comment on attachment 24726 [details]

Comment 3 John Sullivan 2008-10-28 13:40:51 PDT
Comment on attachment 24726 [details]

This doesn't seem right to me. You can't localize a string like "8 files" by localizing the word "files" and appending it to "8 ". You need to localize the entire string, with a wildcard for the number, like "%d files".
Comment 4 Adele Peterson 2008-10-28 16:15:16 PDT
Created attachment 24735 [details]
updated patch
Comment 5 John Sullivan 2008-10-28 16:32:34 PDT
Comment on attachment 24735 [details]
updated patch

I suggest a FIXME for the GTK and Wx ports that says something like "// FIXME: This should really be localizing the entire string with a wildcard for the count"
Comment 6 Adele Peterson 2008-10-28 16:36:54 PDT
Committed revision 37949.