Bug 21880 - "files" string for multifile uploads needs to be localized
: "files" string for multifile uploads needs to be localized
Status: RESOLVED FIXED
: WebKit
Forms
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2008-10-24 21:53 PST by
Modified: 2008-10-28 16:36 PST (History)


Attachments
patch (38.02 KB, patch)
2008-10-28 13:25 PST, Adele Peterson
sullivan: review-
Review Patch | Details | Formatted Diff | Diff
updated patch (9.73 KB, patch)
2008-10-28 16:15 PST, Adele Peterson
sullivan: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2008-10-24 21:53:58 PST
The string we use when you select multiple files for upload needs locatlization
------- Comment #1 From 2008-10-28 13:25:36 PST -------
Created an attachment (id=24726) [details]
patch

This also includes changes to update-webkit-localizable-strings since the script wasn't working with the Mac platform directory structure
------- Comment #2 From 2008-10-28 13:32:02 PST -------
(From update of attachment 24726 [details])
r=me
------- Comment #3 From 2008-10-28 13:40:51 PST -------
(From update of attachment 24726 [details])
This doesn't seem right to me. You can't localize a string like "8 files" by localizing the word "files" and appending it to "8 ". You need to localize the entire string, with a wildcard for the number, like "%d files".
------- Comment #4 From 2008-10-28 16:15:16 PST -------
Created an attachment (id=24735) [details]
updated patch
------- Comment #5 From 2008-10-28 16:32:34 PST -------
(From update of attachment 24735 [details])
I suggest a FIXME for the GTK and Wx ports that says something like "// FIXME: This should really be localizing the entire string with a wildcard for the count"
------- Comment #6 From 2008-10-28 16:36:54 PST -------
Committed revision 37949.