Bug 218789 - REGRESSION(r269665) [GLib] API test /WebKit2Gtk/TestWebKitWebView /webkit/WebKitWebView/page-visibility is failing
Summary: REGRESSION(r269665) [GLib] API test /WebKit2Gtk/TestWebKitWebView /webkit/Web...
Status: RESOLVED DUPLICATE of bug 214804
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-10 22:14 PST by Lauro Moura
Modified: 2020-11-10 22:20 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2020-11-10 22:14:32 PST 
r269665 Removed the `prerender` value from the VisibilityState list of values and the page-visibility API test needs to be updated.

Replacing "prerender" with "hidden" in line 743 of Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp makes the assertion pass but looks like the previous logic of waiting for the title to change after showInWindow needs to be updated, as the onVisibilityChanged seems to not be emitted after it and the waitUntilTitleChanged() call in line 752 makes the test timeout.
Comment 1 Lauro Moura 2020-11-10 22:16:52 PST 
Nevermind, page-visibility already timeouts as pointed by bug214804. Marking this one as duplicated and submitting the prerender fix unreviewed.

*** This bug has been marked as a duplicate of bug 214804 ***
Comment 2 Lauro Moura 2020-11-10 22:20:26 PST 
Updated testvalue in r269673