Bug 218788 – [Media in GPU Process] Update RemoteMediaPlayerMIMETypeCache to add the support for AVFoundationMSE media engine

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Peng Liu]

Update RemoteMediaPlayerMIMETypeCache to add the support for AVFoundationMSE media engine

[Peng Liu]

Created attachment 413781 [details]
WIP patch

[Peng Liu]

Created attachment 413840 [details]
Patch

[Peng Liu]

Comment on attachment 413840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413840&action=review

> Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:-125
> -void RemoteMediaPlayerManager::initialize(const WebProcessCreationParameters& parameters)

Eric, do we need to keep this function?

[Eric Carlson]

Comment on attachment 413840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413840&action=review

> Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerMIMETypeCache.cpp:59
> +        for (auto& type : types)
> +            m_supportedTypesCache.add(type);

You can call addSupportedTypes().

>> Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:-125
>> -void RemoteMediaPlayerManager::initialize(const WebProcessCreationParameters& parameters)
> 
> Eric, do we need to keep this function?

We definitely want to cache WebProcessCreationParameters.mediaMIMETypes so we don't have to ask AVFoundation for MIME types more than once in the life of the host application.

[Peng Liu]

Comment on attachment 413840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413840&action=review

>> Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerMIMETypeCache.cpp:59
>> +            m_supportedTypesCache.add(type);
> 
> You can call addSupportedTypes().

Right! Will fix it.

>>> Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:-125
>>> -void RemoteMediaPlayerManager::initialize(const WebProcessCreationParameters& parameters)
>> 
>> Eric, do we need to keep this function?
> 
> We definitely want to cache WebProcessCreationParameters.mediaMIMETypes so we don't have to ask AVFoundation for MIME types more than once in the life of the host application.

I see! Does parameters.mediaMIMETypes includes supported MIME types of AVFoundation media engine only, or for all other media engines?

[Peng Liu]

Created attachment 413879 [details]
Patch for landing

[EWS]

Committed r269711: <https://trac.webkit.org/changeset/269711>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413879 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71307417>