Bug 218783 - Implementation for AXIsolatedObject methods that return a VisiblePositionRange.
Summary: Implementation for AXIsolatedObject methods that return a VisiblePositionRange.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-10 19:31 PST by Andres Gonzalez
Modified: 2020-11-11 11:14 PST (History)
9 users (show)

See Also:


Attachments
Patch (9.26 KB, patch)
2020-11-10 19:37 PST, Andres Gonzalez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-11-10 19:31:24 PST
Implementation for AXIsolatedObject methods that return a VisiblePositionRange.
Comment 1 Andres Gonzalez 2020-11-10 19:37:25 PST
Created attachment 413763 [details]
Patch
Comment 2 chris fleizach 2020-11-10 21:04:50 PST
Comment on attachment 413763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413763&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:1181
> +    return axObject ? axObject->visiblePositionRange() : VisiblePositionRange();

For the default values I think you can just return { }; now
Comment 3 Andres Gonzalez 2020-11-11 08:30:03 PST
(In reply to chris fleizach from comment #2)
> Comment on attachment 413763 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413763&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:1181
> > +    return axObject ? axObject->visiblePositionRange() : VisiblePositionRange();
> 
> For the default values I think you can just return { }; now

not with ? : operators:
error: initializer list cannot be used on the right hand side of operator ':'
Comment 4 EWS 2020-11-11 11:13:45 PST
Committed r269692: <https://trac.webkit.org/changeset/269692>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413763 [details].
Comment 5 Radar WebKit Bug Importer 2020-11-11 11:14:20 PST
<rdar://problem/71291087>