Bug 218781 - [JSC] wasm fault trampoline should be C code since it is tagged as CFunctionPtr
Summary: [JSC] wasm fault trampoline should be C code since it is tagged as CFunctionPtr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-10 19:18 PST by Yusuke Suzuki
Modified: 2020-11-11 11:52 PST (History)
7 users (show)

See Also:

Attachments
Patch (5.34 KB, patch)
2020-11-10 19:20 PST, Yusuke Suzuki 		keith_miller: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-11-10 19:18:53 PST 
[JSC] wasm fault trampoline should be C code since it is tagged as CFunctionPtr
Comment 1 Yusuke Suzuki 2020-11-10 19:20:12 PST 
Created attachment 413762 [details]
Patch
Comment 2 Mark Lam 2020-11-11 09:58:40 PST 
Comment on attachment 413762 [details]
Patch

In AirIRGenerator::AirIRGenerator(), for the MemoryMode::Signaling case, it checks if (UNLIKELY(!Thunks::singleton().stub(throwExceptionFromWasmThunkGenerator))).  Is that still needed, or is it now obsolete?

Ditto for B3IRGenerator::B3IRGenerator().
Comment 3 Yusuke Suzuki 2020-11-11 11:23:39 PST 
(In reply to Mark Lam from comment #2)
> Comment on attachment 413762 [details]
> Patch
> 
> In AirIRGenerator::AirIRGenerator(), for the MemoryMode::Signaling case, it
> checks if
> (UNLIKELY(!Thunks::singleton().stub(throwExceptionFromWasmThunkGenerator))).
> Is that still needed, or is it now obsolete?
> 
> Ditto for B3IRGenerator::B3IRGenerator().

Right! This is not necessary. Removed.
Comment 4 Yusuke Suzuki 2020-11-11 11:51:26 PST 
Committed r269694: <https://trac.webkit.org/changeset/269694>
Comment 5 Radar WebKit Bug Importer 2020-11-11 11:52:17 PST 
<rdar://problem/71292659>