Bug 218772 - Make PlatformWheelEventPhase an enum class
Summary: Make PlatformWheelEventPhase an enum class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-10 13:43 PST by Simon Fraser (smfr)
Modified: 2020-11-10 16:39 PST (History)
12 users (show)

See Also:

Attachments
Patch (38.71 KB, patch)
2020-11-10 13:45 PST, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-11-10 13:43:16 PST 
Make PlatformWheelEventPhase an enum class
Comment 1 Simon Fraser (smfr) 2020-11-10 13:45:00 PST 
Created attachment 413733 [details]
Patch
Comment 2 Tim Horton 2020-11-10 13:50:39 PST 
Comment on attachment 413733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413733&action=review

> Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:-176
> -    if ([event momentumPhase] & NSEventPhaseBegan)

Weird!

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:1249
> +// FIXME: Need to ensure we get PlatformWheelEventPhase::Ended.

While you're here, indent the comment.
Comment 3 Simon Fraser (smfr) 2020-11-10 16:38:55 PST 
https://trac.webkit.org/r269659
Comment 4 Radar WebKit Bug Importer 2020-11-10 16:39:28 PST 
<rdar://problem/71260959>