Bug 218767 – [LFC][IFC] Add support for replaced element baseline

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

as replaced elements can have set baselines

[zalan]

Created attachment 413722 [details]
Patch

[Antti Koivisto]

Comment on attachment 413722 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413722&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:265
> +            } else if (layoutBox.isReplacedBox())
> +                ascent = downcast<ReplacedBox>(layoutBox).baseline().valueOr(marginBoxHeight);

Should this have a comment that this is an extensions, not something found from spec?

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 413722 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413722&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:265
> > +            } else if (layoutBox.isReplacedBox())
> > +                ascent = downcast<ReplacedBox>(layoutBox).baseline().valueOr(marginBoxHeight);
> 
> Should this have a comment that this is an extensions, not something found
> from spec?
The spec talks about atomic inline box in general in the context of baseline set, so I assume that applies to replaced inline boxes as well.

[EWS]

Committed r269645: <https://trac.webkit.org/changeset/269645>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413722 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71252659>