Bug 218745 - [css-flex] Better naming from some methods
Summary: [css-flex] Better naming from some methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-10 04:17 PST by Sergio Villar Senin
Modified: 2020-11-16 01:52 PST (History)
12 users (show)

See Also:

Attachments
Patch (22.42 KB, patch)
2020-11-10 04:36 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (22.40 KB, patch)
2020-11-11 01:26 PST, Sergio Villar Senin 		jfernandez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2020-11-10 04:17:24 PST 
[css-flex] Better naming from some methods
Comment 1 Sergio Villar Senin 2020-11-10 04:36:01 PST 
Created attachment 413684 [details]
Patch
Comment 2 Javier Fernandez 2020-11-10 04:58:45 PST 
Comment on attachment 413684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413684&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:390
>  {

I'm not totally sure about this change. Somehow, we are using a different concept here; flow vs size. 

What about mainAxisFlowIsChildBlockFlow using the concepts used in the CSS Logical Prooperties [1] about the flow-relative dimensions, based on the Writing Modes terminology [2]

]1] https://www.w3.org/TR/css-logical-1/#directional-keywords
[2] https://www.w3.org/TR/css-writing-modes-4/#block-flow
Comment 3 Sergio Villar Senin 2020-11-10 07:10:55 PST 
Comment on attachment 413684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413684&action=review

>> Source/WebCore/rendering/RenderFlexibleBox.cpp:390
>>  {
> 
> I'm not totally sure about this change. Somehow, we are using a different concept here; flow vs size. 
> 
> What about mainAxisFlowIsChildBlockFlow using the concepts used in the CSS Logical Prooperties [1] about the flow-relative dimensions, based on the Writing Modes terminology [2]
> 
> ]1] https://www.w3.org/TR/css-logical-1/#directional-keywords
> [2] https://www.w3.org/TR/css-writing-modes-4/#block-flow

Makes sense. What about mainAxisIsChildInlineAxis() ? Note that I'm changing the equality bellow, so we no longer check the block but the inline direction.
Comment 4 Javier Fernandez 2020-11-11 01:22:10 PST 
Comment on attachment 413684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413684&action=review

>>> Source/WebCore/rendering/RenderFlexibleBox.cpp:390
>>>  {
>> 
>> I'm not totally sure about this change. Somehow, we are using a different concept here; flow vs size. 
>> 
>> What about mainAxisFlowIsChildBlockFlow using the concepts used in the CSS Logical Prooperties [1] about the flow-relative dimensions, based on the Writing Modes terminology [2]
>> 
>> ]1] https://www.w3.org/TR/css-logical-1/#directional-keywords
>> [2] https://www.w3.org/TR/css-writing-modes-4/#block-flow
> 
> Makes sense. What about mainAxisIsChildInlineAxis() ? Note that I'm changing the equality bellow, so we no longer check the block but the inline direction.

OK
Comment 5 Sergio Villar Senin 2020-11-11 01:26:54 PST 
Created attachment 413797 [details]
Patch
Comment 6 Sergio Villar Senin 2020-11-16 01:51:15 PST 
Committed r269840: <https://trac.webkit.org/changeset/269840>
Comment 7 Radar WebKit Bug Importer 2020-11-16 01:52:17 PST 
<rdar://problem/71431710>