Bug 218745 – [css-flex] Better naming from some methods

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sergio Villar Senin]

[css-flex] Better naming from some methods

[Sergio Villar Senin]

Created attachment 413684 [details]
Patch

[Javier Fernandez]

Comment on attachment 413684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413684&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:390
>  {

I'm not totally sure about this change. Somehow, we are using a different concept here; flow vs size. 

What about mainAxisFlowIsChildBlockFlow using the concepts used in the CSS Logical Prooperties [1] about the flow-relative dimensions, based on the Writing Modes terminology [2]

]1] https://www.w3.org/TR/css-logical-1/#directional-keywords
[2] https://www.w3.org/TR/css-writing-modes-4/#block-flow

[Sergio Villar Senin]

Comment on attachment 413684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413684&action=review

>> Source/WebCore/rendering/RenderFlexibleBox.cpp:390
>>  {
> 
> I'm not totally sure about this change. Somehow, we are using a different concept here; flow vs size. 
> 
> What about mainAxisFlowIsChildBlockFlow using the concepts used in the CSS Logical Prooperties [1] about the flow-relative dimensions, based on the Writing Modes terminology [2]
> 
> ]1] https://www.w3.org/TR/css-logical-1/#directional-keywords
> [2] https://www.w3.org/TR/css-writing-modes-4/#block-flow

Makes sense. What about mainAxisIsChildInlineAxis() ? Note that I'm changing the equality bellow, so we no longer check the block but the inline direction.

[Javier Fernandez]

Comment on attachment 413684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413684&action=review

>>> Source/WebCore/rendering/RenderFlexibleBox.cpp:390
>>>  {
>> 
>> I'm not totally sure about this change. Somehow, we are using a different concept here; flow vs size. 
>> 
>> What about mainAxisFlowIsChildBlockFlow using the concepts used in the CSS Logical Prooperties [1] about the flow-relative dimensions, based on the Writing Modes terminology [2]
>> 
>> ]1] https://www.w3.org/TR/css-logical-1/#directional-keywords
>> [2] https://www.w3.org/TR/css-writing-modes-4/#block-flow
> 
> Makes sense. What about mainAxisIsChildInlineAxis() ? Note that I'm changing the equality bellow, so we no longer check the block but the inline direction.

OK

[Sergio Villar Senin]

Created attachment 413797 [details]
Patch

[Sergio Villar Senin]

Committed r269840: <https://trac.webkit.org/changeset/269840>

[Radar WebKit Bug Importer]

<rdar://problem/71431710>