Bug 218738 - Use GraphicsContext instead of CGContext in RemoteLayerBackingStore
Summary: Use GraphicsContext instead of CGContext in RemoteLayerBackingStore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-09 21:09 PST by Tim Horton
Modified: 2020-11-10 16:48 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.06 KB, patch)
2020-11-09 21:09 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (7.76 KB, patch)
2020-11-09 22:58 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (5.86 KB, patch)
2020-11-09 23:19 PST, Tim Horton 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (8.08 KB, patch)
2020-11-09 23:22 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (7.99 KB, patch)
2020-11-10 16:09 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-11-09 21:09:23 PST 
Use GraphicsContext instead of CGContext in RemoteLayerBackingStore
Comment 1 Tim Horton 2020-11-09 21:09:43 PST 
Created attachment 413660 [details]
Patch
Comment 2 Tim Horton 2020-11-09 22:58:18 PST 
Created attachment 413668 [details]
Patch
Comment 3 Wenson Hsieh 2020-11-09 23:07:13 PST 
Comment on attachment 413668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413668&action=review

> Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:272
> +void RemoteLayerBackingStore::drawInContext(WebCore::GraphicsContext& context, RefPtr<WebCore::NativeImage> backImage)

Nit - I think we generally RefPtr<>&& these, so that we can use move semantics from the call site if possible.
Comment 4 Tim Horton 2020-11-09 23:19:09 PST 
Created attachment 413670 [details]
Patch
Comment 5 Tim Horton 2020-11-09 23:22:00 PST 
Created attachment 413671 [details]
Patch
Comment 6 Tim Horton 2020-11-10 16:09:13 PST 
Created attachment 413755 [details]
Patch
Comment 7 EWS 2020-11-10 16:47:17 PST 
Committed r269664: <https://trac.webkit.org/changeset/269664>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413755 [details].
Comment 8 Radar WebKit Bug Importer 2020-11-10 16:48:22 PST 
<rdar://problem/71261307>