Bug 218736 – [LFC Display] A ContainerBox can establish an inline formatting context and have box children

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Simon Fraser (smfr)]

[LFC Display] A ContainerBox can have establish and inline formatting context and have box children

[Simon Fraser (smfr)]

Created attachment 413656 [details]
Patch

[alan]

Comment on attachment 413656 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413656&action=review

> Source/WebCore/ChangeLog:3
> +        [LFC Display] A ContainerBox can have establish and inline formatting context and have box children

:)

[Radar WebKit Bug Importer]

<rdar://problem/71470058>

[Simon Fraser (smfr)]

Created attachment 414951 [details]
Patch

[Simon Fraser (smfr)]

https://trac.webkit.org/r270198

[Sam Weinig]

Comment on attachment 414951 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414951&action=review

> Source/WebCore/display/DisplayTreeBuilder.cpp:157
> +        switch (boxInclusion) {
> +        case DescendantBoxInclusion::AllBoxes: return true;
> +        case DescendantBoxInclusion::OutOfFlowOnly: return !box.isInFlow();
> +        }

Not a fan of this one line style. Can you move the returns to their own line.

> Source/WebCore/display/DisplayTreeBuilder.cpp:158
> +        return false;

There can probably a be an ASSERT_NOT_REACHED here for good measure.

[Sam Weinig]

Should this still be up for review?