[LFC Display] A ContainerBox can have establish and inline formatting context and have box children
Created attachment 413656 [details] Patch
Comment on attachment 413656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413656&action=review > Source/WebCore/ChangeLog:3 > + [LFC Display] A ContainerBox can have establish and inline formatting context and have box children :)
<rdar://problem/71470058>
Created attachment 414951 [details] Patch
https://trac.webkit.org/r270198
Comment on attachment 414951 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414951&action=review > Source/WebCore/display/DisplayTreeBuilder.cpp:157 > + switch (boxInclusion) { > + case DescendantBoxInclusion::AllBoxes: return true; > + case DescendantBoxInclusion::OutOfFlowOnly: return !box.isInFlow(); > + } Not a fan of this one line style. Can you move the returns to their own line. > Source/WebCore/display/DisplayTreeBuilder.cpp:158 > + return false; There can probably a be an ASSERT_NOT_REACHED here for good measure.
Should this still be up for review?