garbage is rendered on speakers when using WebAudio and when enabling the GPU Process.
Easily testable with this demo:
This is a regression from using a CARingBuffer.
Created attachment 413644 [details]
Comment on attachment 413644 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=413644&action=review
> + remain to processed (usually 0). As a result, RemoteAudioDestinationProxy::renderOnRenderingThead()
Good catch! I misunderstood the comment of PushPullFIFO::pull(). The return value of this function is the number of samples *left* in the FIFO, not the number of samples fetched from the FIFO.
> completionHandler(0, 0);
Not a problem of this patch. But we have to early return here after calling completionHandler().
Created attachment 413697 [details]
Committed r269630: <https://trac.webkit.org/changeset/269630>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 413697 [details].