Bug 218728 - Stop using objc_autoreleasePool{Push, Pop} in RunLoop observers
Summary: Stop using objc_autoreleasePool{Push, Pop} in RunLoop observers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-09 16:11 PST by Geoffrey Garen
Modified: 2022-02-27 23:59 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.37 KB, patch)
2020-11-09 16:29 PST, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (3.75 KB, patch)
2020-11-10 11:34 PST, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (7.16 KB, patch)
2020-11-10 13:45 PST, Geoffrey Garen 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (7.16 KB, patch)
2020-11-10 15:14 PST, Geoffrey Garen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (7.16 KB, patch)
2020-11-10 15:23 PST, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2020-11-09 16:11:20 PST 
Stop using deprecated objc_autoreleasePool{Push, Pop}
Comment 1 Geoffrey Garen 2020-11-09 16:13:38 PST 
rdar://problem/67283410
Comment 2 Geoffrey Garen 2020-11-09 16:29:54 PST 
Created attachment 413642 [details]
Patch
Comment 3 Geoffrey Garen 2020-11-10 11:34:28 PST 
Created attachment 413719 [details]
Patch
Comment 4 Chris Dumez 2020-11-10 13:05:58 PST 
Comment on attachment 413719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413719&action=review

> Source/WebCore/platform/ios/wak/WebCoreThread.mm:60
> +static inline bool _CFRunLoopSetPerCalloutAutoreleasepoolEnabled(BOOL)

Don't we usually do a forward-declaration for those things instead of providing our own implementation? Like we do in all our *SPI.h headers?
Comment 5 Tim Horton 2020-11-10 13:30:00 PST 
Comment on attachment 413719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413719&action=review

>> Source/WebCore/platform/ios/wak/WebCoreThread.mm:60
>> +static inline bool _CFRunLoopSetPerCalloutAutoreleasepoolEnabled(BOOL)
> 
> Don't we usually do a forward-declaration for those things instead of providing our own implementation? Like we do in all our *SPI.h headers?

Yes (and technically it should be /in/ a SPI header... see CFBundleSPI or CFStringSPI, and make a CFRunLoopSPI).
Comment 6 Geoffrey Garen 2020-11-10 13:45:24 PST 
Created attachment 413734 [details]
Patch
Comment 7 Tim Horton 2020-11-10 14:39:26 PST 
Comment on attachment 413734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413734&action=review

> Source/WTF/wtf/spi/cf/CFRunLoopSPI.h:2
> + * Copyright (C) 2017 Apple Inc.  All rights reserved.

If only
Comment 8 Geoffrey Garen 2020-11-10 15:14:38 PST 
Created attachment 413746 [details]
Patch for landing
Comment 9 EWS 2020-11-10 15:15:26 PST 
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Comment 10 Geoffrey Garen 2020-11-10 15:23:04 PST 
Created attachment 413748 [details]
Patch for landing
Comment 11 EWS 2020-11-10 15:53:33 PST 
Committed r269658: <https://trac.webkit.org/changeset/269658>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413748 [details].