Bug 218727 – Add support for AudioConfiguration.spatialRendering

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Add support for AudioConfiguration.spatialRendering

[Radar WebKit Bug Importer]

<rdar://problem/71213348>

[Jer Noble]

Created attachment 413636 [details]
Patch

[Eric Carlson]

Comment on attachment 413636 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413636&action=review

> Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:42
> +    : m_context(context)

WTFMove(context)

> Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:90
> +        if (auto* outputDevice = [m_context outputDevice])

Nit: '*' on the wrong side.

> Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:95
> +    auto* avOutputDevices = [m_context outputDevices];

Ditto

> Source/WebCore/PAL/pal/avfoundation/OutputDevice.mm:47
> +uint8_t OutputDevice::deviceFeatures() const

You could use std::bitset<>

[Peng Liu]

Comment on attachment 413636 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413636&action=review

> Source/WebCore/PAL/pal/avfoundation/OutputContext.h:38
> +class OutputContext {

Is this for audio output only?

> Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:48
> +    static NeverDestroyed<Optional<OutputContext>> sharedAudioPresentationOutputContext = [] () -> Optional<OutputContext> {

Nit. The space between [] and () can be removed.

> Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:103
> +

Nit. An extra space.

> Source/WebCore/platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp:133
> +            if (!context || !WTF::allOf(context->outputDevices(), [] (auto& device) {

Nit. The space between [] and () can be removed.

[Jer Noble]

Created attachment 413638 [details]
Patch for landing

[Jer Noble]

(In reply to Peng Liu from comment #4)
> Comment on attachment 413636 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413636&action=review
> 
> > Source/WebCore/PAL/pal/avfoundation/OutputContext.h:38
> > +class OutputContext {
> 
> Is this for audio output only?

Not necessarily; it is also used for remote video playback over AirPlay or through an external TV screen.

> > Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:48
> > +    static NeverDestroyed<Optional<OutputContext>> sharedAudioPresentationOutputContext = [] () -> Optional<OutputContext> {
> 
> Nit. The space between [] and () can be removed.

Won't the style checker complain about that?

[EWS]

Committed r269631: <https://trac.webkit.org/changeset/269631>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413638 [details].