WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
218727
Add support for AudioConfiguration.spatialRendering
https://bugs.webkit.org/show_bug.cgi?id=218727
Summary
Add support for AudioConfiguration.spatialRendering
Jer Noble
Reported
2020-11-09 15:16:44 PST
Add support for AudioConfiguration.spatialRendering
Attachments
Patch
(33.65 KB, patch)
2020-11-09 15:21 PST
,
Jer Noble
eric.carlson
: review+
Details
Formatted Diff
Diff
Patch for landing
(34.07 KB, patch)
2020-11-09 16:13 PST
,
Jer Noble
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2020-11-09 15:17:24 PST
<
rdar://problem/71213348
>
Jer Noble
Comment 2
2020-11-09 15:21:41 PST
Created
attachment 413636
[details]
Patch
Eric Carlson
Comment 3
2020-11-09 16:06:10 PST
Comment on
attachment 413636
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=413636&action=review
> Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:42 > + : m_context(context)
WTFMove(context)
> Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:90 > + if (auto* outputDevice = [m_context outputDevice])
Nit: '*' on the wrong side.
> Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:95 > + auto* avOutputDevices = [m_context outputDevices];
Ditto
> Source/WebCore/PAL/pal/avfoundation/OutputDevice.mm:47 > +uint8_t OutputDevice::deviceFeatures() const
You could use std::bitset<>
Peng Liu
Comment 4
2020-11-09 16:09:40 PST
Comment on
attachment 413636
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=413636&action=review
> Source/WebCore/PAL/pal/avfoundation/OutputContext.h:38 > +class OutputContext {
Is this for audio output only?
> Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:48 > + static NeverDestroyed<Optional<OutputContext>> sharedAudioPresentationOutputContext = [] () -> Optional<OutputContext> {
Nit. The space between [] and () can be removed.
> Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:103 > +
Nit. An extra space.
> Source/WebCore/platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp:133 > + if (!context || !WTF::allOf(context->outputDevices(), [] (auto& device) {
Nit. The space between [] and () can be removed.
Jer Noble
Comment 5
2020-11-09 16:13:40 PST
Created
attachment 413638
[details]
Patch for landing
Jer Noble
Comment 6
2020-11-09 16:15:10 PST
(In reply to Peng Liu from
comment #4
)
> Comment on
attachment 413636
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=413636&action=review
> > > Source/WebCore/PAL/pal/avfoundation/OutputContext.h:38 > > +class OutputContext { > > Is this for audio output only?
Not necessarily; it is also used for remote video playback over AirPlay or through an external TV screen.
> > Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:48 > > + static NeverDestroyed<Optional<OutputContext>> sharedAudioPresentationOutputContext = [] () -> Optional<OutputContext> { > > Nit. The space between [] and () can be removed.
Won't the style checker complain about that?
EWS
Comment 7
2020-11-10 11:10:55 PST
Committed
r269631
: <
https://trac.webkit.org/changeset/269631
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 413638
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug