RESOLVED FIXED 218695
Show legacy line layout visual coverage instead of "simple line" layout. 
https://bugs.webkit.org/show_bug.cgi?id=218695
Summary Show legacy line layout visual coverage instead of "simple line" layout.
zalan
Reported 2020-11-08 16:13:08 PST
it's time to swap this.
Attachments
Patch (26.87 KB, patch)
2020-11-08 16:17 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (43.49 KB, patch)
2020-11-09 12:13 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (43.52 KB, patch)
2020-11-09 12:33 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2020-11-08 16:17:47 PST
Created attachment 413547 [details] Patch
zalan
Comment 2 2020-11-09 12:13:02 PST
Created attachment 413616 [details] Patch
zalan
Comment 3 2020-11-09 12:33:04 PST
Created attachment 413619 [details] Patch
Sam Weinig
Comment 4 2020-11-09 12:40:23 PST
Comment on attachment 413619 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413619&action=review > Source/WTF/ChangeLog:8 > + * Scripts/Preferences/WebPreferencesDebug.yaml: I feel like maybe we should merge Debug and Internal preferences, as it seems silly to need to need to do all this plumbing to have the settings show up in minibrowser. Do you use the Debug nature of the setting (e.g. that it can be set globally for any WKWebView)?
Sam Weinig
Comment 5 2020-11-09 12:43:07 PST
Comment on attachment 413619 [details] Patch Antti r+'d this and bugzilla decided I meant to un-r+, which I didn't :( Sorry.
zalan
Comment 6 2020-11-09 13:01:08 PST
(In reply to Sam Weinig from comment #4) > Comment on attachment 413619 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413619&action=review > > > Source/WTF/ChangeLog:8 > > + * Scripts/Preferences/WebPreferencesDebug.yaml: > > I feel like maybe we should merge Debug and Internal preferences, as it > seems silly to need to need to do all this plumbing to have the settings > show up in minibrowser. Do you use the Debug nature of the setting (e.g. > that it can be set globally for any WKWebView)? I am fine with merging them.
EWS
Comment 7 2020-11-09 14:28:39 PST
Committed r269603: <https://trac.webkit.org/changeset/269603> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413619 [details].
Radar WebKit Bug Importer
Comment 8 2020-11-09 14:29:19 PST
<rdar://problem/71210962>
zalan
Comment 9 2020-11-09 14:54:28 PST
Reverted r269603 for reason: Needs Safari patch Committed r269605: <https://trac.webkit.org/changeset/269605>
zalan
Comment 10 2020-11-09 16:01:30 PST
(In reply to Sam Weinig from comment #4) > Comment on attachment 413619 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413619&action=review > > > Source/WTF/ChangeLog:8 > > + * Scripts/Preferences/WebPreferencesDebug.yaml: > > I feel like maybe we should merge Debug and Internal preferences, as it > seems silly to need to need to do all this plumbing to have the settings > show up in minibrowser. Do you use the Debug nature of the setting (e.g. > that it can be set globally for any WKWebView)? Actually let me do that instead.
zalan
Comment 11 2020-11-12 02:51:09 PST
Committed r269726: <https://trac.webkit.org/changeset/269726>
Note You need to log in before you can comment on or make changes to this bug.