Bug 21869 - Some .idl files generate code that is never built
Summary: Some .idl files generate code that is never built
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-24 14:26 PDT by Greg Bolsinga
Modified: 2008-10-25 04:41 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Bolsinga 2008-10-24 14:26:13 PDT
SQLTransactionCallback.idl, SQLTransactionErrorCallback.idl, PositionCallback.idl, PositionErrorCallback.idl are a few of the examples David Kilzer and I noticed today.

The reason is that they have JSCustom* items and the handleEvent() method in these needs a bool& parameter.

Adding raises(DOMException) does not address this issue.
Comment 1 David Kilzer (:ddkilzer) 2008-10-24 14:29:44 PDT
Basically, there should be a way to tell the generate-bindings.pl script (via CodeGeneratorJS.pm) that we don't want to create JS*.[cpp|h] files for these *.idl files.  Not sure if there is an existing "Custom" attribute that's missing, or if a new one needs to be added.
Comment 2 David Kilzer (:ddkilzer) 2008-10-24 14:41:34 PDT
The GTK build may be broken until this is resolved:

DerivedSources/JSPositionCallback.cpp: In function 'JSC::JSValue* WebCore::jsPositionCallbackPrototypeFunctionHandleEvent(JSC::ExecState*, JSC::JSObject*, JSC::JSValue*, const JSC::ArgList&)':
DerivedSources/JSPositionCallback.cpp:145: error: no matching function for call to 'WebCore::PositionCallback::handleEvent(WebCore::Geoposition*&)'
/home/oe/webkit/source/WebKit-BuildSlave/trunk-gtk-linux-release/build/WebCore/page/PositionCallback.h:39: note: candidates are: virtual void WebCore::PositionCallback::handleEvent(WebCore::Geoposition*, bool&)

http://build.webkit.org/builders/trunk-gtk-linux-release/builds/1416
Comment 3 David Kilzer (:ddkilzer) 2008-10-24 14:48:37 PDT
(In reply to comment #2)
> The GTK build may be broken until this is resolved:

Scratch that.  Fix coming (some *.idl shouldn't be included in GNUmakefile.am).
Comment 4 David Kilzer (:ddkilzer) 2008-10-24 14:54:47 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > The GTK build may be broken until this is resolved:
> Scratch that.  Fix coming (some *.idl shouldn't be included in GNUmakefile.am).

See:  Bug 21475 Comment #27
Comment 5 David Kilzer (:ddkilzer) 2008-10-25 04:41:35 PDT
See Bug 15406 for some shell scripts to find generated files that aren't included in Xcode projects.