Bug 218688 – Receiving two enter/exit fullscreen delegate callbacks on iPad when presenting fullscreen elements

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Peng Liu]

Receiving two enter/exit fullscreen delegate callbacks on iPad when presenting fullscreen elements

[Peng Liu]

<rdar://problem/70546084>

[Peng Liu]

Created attachment 413531 [details]
WIP patch (need an API test)

[Peng Liu]

Created attachment 413537 [details]
WIP patch (need an API test)

[Peng Liu]

Just realized that I need to fix bug 212654 before adding a test for this patch.

[Darin Adler]

Comment on attachment 413537 [details]
WIP patch (need an API test)

View in context: https://bugs.webkit.org/attachment.cgi?id=413537&action=review

> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:936
> +    if (mode == HTMLMediaElementEnums::VideoFullscreenModeNone && standby)
> +        m_changingStandbyOnly = true;
> +    else
> +        m_changingStandbyOnly = false;

m_changingStandbyOnly = mode == HTMLMediaElementEnums::VideoFullscreenModeNone && standby;

> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:972
> +    if (!m_currentMode.hasVideo() && m_standby)
> +        m_changingStandbyOnly = true;
> +    else
> +        m_changingStandbyOnly = false;

m_changingStandbyOnly = !m_currentMode.hasVideo() && m_standby;

[Peng Liu]

Created attachment 417415 [details]
Patch for landing

[Peng Liu]

Comment on attachment 413537 [details]
WIP patch (need an API test)

View in context: https://bugs.webkit.org/attachment.cgi?id=413537&action=review

>> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:936
>> +        m_changingStandbyOnly = false;
> 
> m_changingStandbyOnly = mode == HTMLMediaElementEnums::VideoFullscreenModeNone && standby;

Good idea! Fixed.

>> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:972
>> +        m_changingStandbyOnly = false;
> 
> m_changingStandbyOnly = !m_currentMode.hasVideo() && m_standby;

Fixed.

[EWS]

Committed r271387: <https://trac.webkit.org/changeset/271387>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417415 [details].