Bug 218677 - Unexpose obsolete HTMLAppletElement interface
Summary: Unexpose obsolete HTMLAppletElement interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
: 157926 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-11-06 17:08 PST by Chris Dumez
Modified: 2022-07-05 13:57 PDT (History)
28 users (show)

See Also:


Attachments
WIP Patch (65.91 KB, patch)
2020-11-06 17:08 PST, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP Patch (9.61 KB, patch)
2020-11-09 08:59 PST, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP Patch (10.08 KB, patch)
2020-11-09 09:23 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (15.06 KB, patch)
2020-11-09 09:57 PST, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP Patch (97.02 KB, patch)
2020-11-09 11:08 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (205.13 KB, patch)
2020-11-09 12:02 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (208.22 KB, patch)
2020-11-09 14:07 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (209.38 KB, patch)
2020-11-09 14:13 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (229.74 KB, patch)
2020-11-09 14:21 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-11-06 17:08:14 PST
Drop support for HTMLAppletElement. It has been dropped already from the HTML specification, from Blink and Gecko engines.
Comment 1 Chris Dumez 2020-11-06 17:08:53 PST
Created attachment 413499 [details]
WIP Patch
Comment 2 EWS Watchlist 2020-11-06 17:09:45 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Chris Dumez 2020-11-09 08:59:22 PST
Created attachment 413591 [details]
WIP Patch
Comment 4 Chris Dumez 2020-11-09 09:23:21 PST
Created attachment 413595 [details]
WIP Patch
Comment 5 Chris Dumez 2020-11-09 09:57:12 PST
Created attachment 413597 [details]
WIP Patch
Comment 6 Chris Dumez 2020-11-09 11:08:57 PST
Created attachment 413603 [details]
WIP Patch
Comment 7 Chris Dumez 2020-11-09 12:02:57 PST
Created attachment 413615 [details]
Patch
Comment 8 Darin Adler 2020-11-09 13:36:17 PST
Comment on attachment 413615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413615&action=review

I suspect there is a bit more that can be removed afterwards.

> Source/WebCore/html/HTMLPlugInImageElement.h:32
> +// Base class for HTMLEmbedElement, and HTMLObjectElement.

Should remove the "," here.

> Source/WebCore/html/HTMLTagNames.in:11
> +applet interfaceName=HTMLUnknownElement

Why do we need this? What is the benefit over just removing the tag name entirely instead?

> Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLAppletElementPrivate.h:20
>  #ifndef WebKitDOMHTMLAppletElementPrivate_h

Seems like someone with enough knowledge of how things are used could remove this entire header instead.

> Source/WebKitLegacy/mac/DOM/DOMHTMLAppletElement.mm:30
>  #import <WebCore/HTMLNames.h>

Can remove most of these includes, maybe all.

> LayoutTests/fast/dom/plugin-attributes-enumeration-expected.txt:35
>  APPLET also has:

Should we change the test to remove this?
Comment 9 Chris Dumez 2020-11-09 13:40:43 PST
Comment on attachment 413615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413615&action=review

>> Source/WebCore/html/HTMLTagNames.in:11
>> +applet interfaceName=HTMLUnknownElement
> 
> Why do we need this? What is the benefit over just removing the tag name entirely instead?

I tried what you suggested first but this was causing some WPT tests failures. Support for <applet> has not been removed at HTML parser level.
Comment 10 Chris Dumez 2020-11-09 14:07:08 PST
Created attachment 413631 [details]
Patch
Comment 11 Chris Dumez 2020-11-09 14:13:42 PST
Created attachment 413632 [details]
Patch
Comment 12 Geoffrey Garen 2020-11-09 14:16:25 PST
Relatedly, these files can be removed from the ManualTests folder:

accessibility/java-applet.html
accessibility/resources/AppletTest.java
applet-finish-parsing-children.html
applet-param-no-name.html
java-string-object-type.html
liveconnect-applet-array-parameters.html
liveconnect-applet-get-boolean.html
liveconnect-security-exception.html
resources/DrawMessage.class
resources/ArrayParameterTestApplet.class
resources/liveconnect-security-exception-popup.html
resources/CheckerApplet.java
resources/ArrayParameterTestApplet.java
resources/TestApplet.class
resources/StringTypeTest.class
resources/CheckerApplet.class
resources/TestApplet.java
resources/StringTypeTest.java
Comment 13 Chris Dumez 2020-11-09 14:21:02 PST
Created attachment 413634 [details]
Patch
Comment 14 Chris Dumez 2020-11-09 14:21:37 PST
(In reply to Geoffrey Garen from comment #12)
> Relatedly, these files can be removed from the ManualTests folder:
> 
> accessibility/java-applet.html
> accessibility/resources/AppletTest.java
> applet-finish-parsing-children.html
> applet-param-no-name.html
> java-string-object-type.html
> liveconnect-applet-array-parameters.html
> liveconnect-applet-get-boolean.html
> liveconnect-security-exception.html
> resources/DrawMessage.class
> resources/ArrayParameterTestApplet.class
> resources/liveconnect-security-exception-popup.html
> resources/CheckerApplet.java
> resources/ArrayParameterTestApplet.java
> resources/TestApplet.class
> resources/StringTypeTest.class
> resources/CheckerApplet.class
> resources/TestApplet.java
> resources/StringTypeTest.java

Thanks, I dropped these too. I did not even know this folder existed :)
Comment 15 EWS 2020-11-09 16:29:30 PST
Committed r269612: <https://trac.webkit.org/changeset/269612>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413634 [details].
Comment 16 Radar WebKit Bug Importer 2020-11-09 16:30:21 PST
<rdar://problem/71216453>
Comment 17 Sam Sneddon [:gsnedders] 2022-07-05 13:57:43 PDT
*** Bug 157926 has been marked as a duplicate of this bug. ***