Bug 218666 – Add total counts to sampling profiler dump

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Keith Miller]

Add total counts to sampling profiler dump

[Keith Miller]

Created attachment 413456 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 413456 [details]
Patch

r=me

[Mark Lam]

Comment on attachment 413456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413456&action=review

> Source/JavaScriptCore/runtime/SamplingProfiler.cpp:1026
> +    size_t totalCount = 0;

Can you name this totalSamples instead?  The meaning of "count" is nebulous.  What you're really measuring is the number of samples processed.  So, let's call it that.

> Source/JavaScriptCore/runtime/SamplingProfiler.cpp:1087
> +    size_t totalCount = 0;

Ditto, name this totalSamples.

> Source/JavaScriptCore/runtime/SamplingProfiler.cpp:1142
> +        out.println("\n\nSampling rate: ", m_timingInterval.microseconds(), " microseconds. Total count: ", totalCount);

/Total count:/Total Samples:/

[Keith Miller]

Comment on attachment 413456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413456&action=review

>> Source/JavaScriptCore/runtime/SamplingProfiler.cpp:1026
>> +    size_t totalCount = 0;
> 
> Can you name this totalSamples instead?  The meaning of "count" is nebulous.  What you're really measuring is the number of samples processed.  So, let's call it that.

Sure.

[Keith Miller]

Created attachment 413614 [details]
Patch for landing

[EWS]

Committed r269597: <https://trac.webkit.org/changeset/269597>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413614 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71207171>