Bug 218666 - Add total counts to sampling profiler dump
Summary: Add total counts to sampling profiler dump
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-06 11:59 PST by Keith Miller
Modified: 2020-11-09 13:19 PST (History)
7 users (show)

See Also:

Attachments
Patch (4.25 KB, patch)
2020-11-06 12:00 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (4.28 KB, patch)
2020-11-09 12:02 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-11-06 11:59:21 PST 
Add total counts to sampling profiler dump
Comment 1 Keith Miller 2020-11-06 12:00:48 PST 
Created attachment 413456 [details]
Patch
Comment 2 Yusuke Suzuki 2020-11-06 13:37:33 PST 
Comment on attachment 413456 [details]
Patch

r=me
Comment 3 Mark Lam 2020-11-06 17:46:31 PST 
Comment on attachment 413456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413456&action=review

> Source/JavaScriptCore/runtime/SamplingProfiler.cpp:1026
> +    size_t totalCount = 0;

Can you name this totalSamples instead?  The meaning of "count" is nebulous.  What you're really measuring is the number of samples processed.  So, let's call it that.

> Source/JavaScriptCore/runtime/SamplingProfiler.cpp:1087
> +    size_t totalCount = 0;

Ditto, name this totalSamples.

> Source/JavaScriptCore/runtime/SamplingProfiler.cpp:1142
> +        out.println("\n\nSampling rate: ", m_timingInterval.microseconds(), " microseconds. Total count: ", totalCount);

/Total count:/Total Samples:/
Comment 4 Keith Miller 2020-11-09 11:57:17 PST 
Comment on attachment 413456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413456&action=review

>> Source/JavaScriptCore/runtime/SamplingProfiler.cpp:1026
>> +    size_t totalCount = 0;
> 
> Can you name this totalSamples instead?  The meaning of "count" is nebulous.  What you're really measuring is the number of samples processed.  So, let's call it that.

Sure.
Comment 5 Keith Miller 2020-11-09 12:02:38 PST 
Created attachment 413614 [details]
Patch for landing
Comment 6 EWS 2020-11-09 13:18:30 PST 
Committed r269597: <https://trac.webkit.org/changeset/269597>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413614 [details].
Comment 7 Radar WebKit Bug Importer 2020-11-09 13:19:19 PST 
<rdar://problem/71207171>