Bug 218663 - Further progress towards merging Settings.yaml into WebPreferences.yaml
Summary: Further progress towards merging Settings.yaml into WebPreferences.yaml
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-06 11:11 PST by Sam Weinig
Modified: 2020-11-06 17:48 PST (History)
10 users (show)

See Also:

Attachments
Patch (36.09 KB, patch)
2020-11-06 11:28 PST, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (37.66 KB, patch)
2020-11-06 12:07 PST, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-11-06 11:11:06 PST 
Further progress towards merging Settings.yaml into WebPreferences.yaml
Comment 1 Sam Weinig 2020-11-06 11:28:49 PST 
Created attachment 413451 [details]
Patch
Comment 2 Sam Weinig 2020-11-06 12:07:11 PST 
Created attachment 413459 [details]
Patch
Comment 3 Tim Horton 2020-11-06 13:29:26 PST 
Comment on attachment 413459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413459&action=review

> Source/WTF/Scripts/Preferences/WebPreferences.yaml:1291
>        "PLATFORM(IOS_FAMILY)": false

Can we collapse down ones where it's the same in all three, or is that not a thing?
Comment 4 Sam Weinig 2020-11-06 15:12:40 PST 
(In reply to Tim Horton from comment #3)
> Comment on attachment 413459 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413459&action=review
> 
> > Source/WTF/Scripts/Preferences/WebPreferences.yaml:1291
> >        "PLATFORM(IOS_FAMILY)": false
> 
> Can we collapse down ones where it's the same in all three, or is that not a
> thing?

Not a thing at the moment. I decide to be very explicit for now. Once everything is there we can consider brevity though.
Comment 5 EWS 2020-11-06 15:28:12 PST 
Committed r269545: <https://trac.webkit.org/changeset/269545>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413459 [details].
Comment 6 Radar WebKit Bug Importer 2020-11-06 15:29:18 PST 
<rdar://problem/71135486>