Bug 218663 – Further progress towards merging Settings.yaml into WebPreferences.yaml

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Further progress towards merging Settings.yaml into WebPreferences.yaml

[Sam Weinig]

Created attachment 413451 [details]
Patch

[Sam Weinig]

Created attachment 413459 [details]
Patch

[Tim Horton]

Comment on attachment 413459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413459&action=review

> Source/WTF/Scripts/Preferences/WebPreferences.yaml:1291
>        "PLATFORM(IOS_FAMILY)": false

Can we collapse down ones where it's the same in all three, or is that not a thing?

[Sam Weinig]

(In reply to Tim Horton from comment #3)
> Comment on attachment 413459 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413459&action=review
> 
> > Source/WTF/Scripts/Preferences/WebPreferences.yaml:1291
> >        "PLATFORM(IOS_FAMILY)": false
> 
> Can we collapse down ones where it's the same in all three, or is that not a
> thing?

Not a thing at the moment. I decide to be very explicit for now. Once everything is there we can consider brevity though.

[EWS]

Committed r269545: <https://trac.webkit.org/changeset/269545>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413459 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71135486>