Bug 218662 - REGRESSION (r269435): [iOS Debug] ASSERTION FAILED: !m_impl || Thread::mayBeGCThread() || m_impl->wasConstructedOnMainThread() == isMainThread()
Summary: REGRESSION (r269435): [iOS Debug] ASSERTION FAILED: !m_impl || Thread::mayBeG...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-06 10:12 PST by Ryan Haddad
Modified: 2020-11-06 22:56 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.47 KB, patch)
2020-11-06 17:39 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2020-11-06 10:12:06 PST 
The following two API tests are consistently failing an assertion on iOS Debug bots:

TestWebKitAPI.WebKitLegacy.WebGLNoCrashOnOtherThreadAccess
TestWebKitAPI.WebKitLegacy.WebGLPrepareDisplayOnWebThread

https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWebKitAPI.WebKitLegacy.WebGLNoCrashOnOtherThreadAccess&test=TestWebKitAPI.WebKitLegacy.WebGLPrepareDisplayOnWebThread

        ASSERTION FAILED: !m_impl || Thread::mayBeGCThread() || m_impl->wasConstructedOnMainThread() == isMainThread()
        /Volumes/Data/slave/ios-simulator-14-debug/build/WebKitBuild/Debug-iphonesimulator/usr/local/include/wtf/WeakPtr.h(94) : T *WTF::WeakPtr<WebCore::Page, WTF::EmptyCounter>::get() const [T = WebCore::Page, Counter = WTF::EmptyCounter]
        1   0x108c65689 WTFCrash
        2   0x11dcab23b WTFCrashWithInfo(int, char const*, char const*, int)
        3   0x11efd4f66 WTF::WeakPtr<WebCore::Page, WTF::EmptyCounter>::get() const
        4   0x1216cc8fe WebCore::Frame::page() const
        5   0x120214226 WebCore::ScriptController::canExecuteScripts(WebCore::ReasonForCallingCanExecuteScripts)
        6   0x11e3dc151 WebCore::ScriptController::javaScriptContext()
        7   0x1396a9666 -[WebFrame javaScriptContext]
        8   0x106c1d756 -[NSObject(NSKeyValueCoding) valueForKey:]
        9   0x106c1e1f0 -[NSObject(NSKeyValueCoding) valueForKeyPath:]
        10  0x106c1e1f0 -[NSObject(NSKeyValueCoding) valueForKeyPath:]
        11  0x106c1e1f0 -[NSObject(NSKeyValueCoding) valueForKeyPath:]
        12  0x1025f8a7f TestWebKitAPI::WebKitLegacy_WebGLNoCrashOnOtherThreadAccess_Test::TestBody()
        13  0x10276f2a4 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        14  0x10274c2eb void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        15  0x10274c226 testing::Test::Run()
        16  0x10274d05a testing::TestInfo::Run()
        17  0x10274de84 testing::TestCase::Run()
        18  0x102758cf8 testing::internal::UnitTestImpl::RunAllTests()
        19  0x102773974 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        20  0x10275880b bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        21  0x1027586dd testing::UnitTest::Run()
        22  0x10258de21 RUN_ALL_TESTS()
        23  0x10258ddb2 TestWebKitAPI::TestsController::run(int, char**)
        24  0x10271f28d main
        25  0x1085ca415 start
        Child process terminated with signal 11: Segmentation fault
Comment 1 Radar WebKit Bug Importer 2020-11-06 10:12:25 PST 
<rdar://problem/71123941>
Comment 2 Ryan Haddad 2020-11-06 10:56:22 PST 
We have a gap in test results because of a build breakage, but I think this may be related to https://trac.webkit.org/changeset/269435/webkit#file18
Comment 3 Alex Christensen 2020-11-06 17:39:35 PST 
Created attachment 413504 [details]
Patch
Comment 4 EWS 2020-11-06 22:55:59 PST 
Committed r269560: <https://trac.webkit.org/changeset/269560>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413504 [details].