Bug 218660 – Look at parents when event bubbles for input element activation behavior

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Look at parents when event bubbles for input element activation behavior.

[Chris Dumez]

Created attachment 413439 [details]
WIP Patch

[Chris Dumez]

Created attachment 413440 [details]
WIP Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Chris Dumez]

Created attachment 413461 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 413461 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413461&action=review

> Source/WebCore/dom/EventDispatcher.cpp:159
> +    RefPtr<HTMLInputElement> input = is<HTMLInputElement>(node) ? &downcast<HTMLInputElement>(node) : nullptr;
> +    if (!input && event.type() == eventNames().clickEvent && event.bubbles())
> +        input = findInputElementInEventPath(eventPath);

To make the relationship with the spec language more clear, can we define a boolean called:
isActivationEvent = event.type() == eventNames().clickEvent
and input to something like inputWithLegacyPreActivationBehavior?

[Chris Dumez]

Created attachment 413588 [details]
Patch

[EWS]

Committed r269582: <https://trac.webkit.org/changeset/269582>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413588 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71195341>