Bug 218658 - Remove experimental: and internal: prefixes from recently added tests
Summary: Remove experimental: and internal: prefixes from recently added tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-06 07:59 PST by Aditya Keerthi
Modified: 2020-11-09 12:26 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.47 KB, patch)
2020-11-06 08:00 PST, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2020-11-06 07:59:31 PST 
...
Comment 1 Aditya Keerthi 2020-11-06 08:00:59 PST 
Created attachment 413432 [details]
Patch
Comment 2 Devin Rousso 2020-11-09 12:00:36 PST 
Comment on attachment 413432 [details]
Patch

rs=me
Comment 3 Sam Weinig 2020-11-09 12:11:31 PST 
Any idea why these tests aren't failing (or are they somewhere)?
Comment 4 EWS 2020-11-09 12:21:58 PST 
Committed r269594: <https://trac.webkit.org/changeset/269594>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413432 [details].
Comment 5 Radar WebKit Bug Importer 2020-11-09 12:22:19 PST 
<rdar://problem/71204507>
Comment 6 Aditya Keerthi 2020-11-09 12:26:37 PST 
(In reply to Sam Weinig from comment #3)
> Any idea why these tests aren't failing (or are they somewhere)?

I didn't observe these tests failing anywhere.

The scrolling test is a ref test that would trivially pass if the test options were not honored.

But I'm not sure how the contact-picker tests were passing, since the API is disabled in `WebPreferencesExperimental.yaml`.