RESOLVED FIXED 218657
[macOS] Add IOKIt message filtering 
https://bugs.webkit.org/show_bug.cgi?id=218657
Summary [macOS] Add IOKIt message filtering
Per Arne Vollan
Reported 2020-11-06 07:23:14 PST
Like on iOS, the WebContent process on macOS should have IOKit message filtering as well.
Attachments
Patch (10.33 KB, patch)
2020-11-06 07:45 PST, Per Arne Vollan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (9.83 KB, patch)
2020-11-06 12:21 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (10.04 KB, patch)
2020-11-06 12:27 PST, Per Arne Vollan 		bfulgham: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (9.98 KB, patch)
2020-11-06 13:09 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-11-06 07:23:33 PST
<rdar://problem/71118545>
Per Arne Vollan
Comment 2 2020-11-06 07:45:13 PST
Created attachment 413430 [details] Patch
Per Arne Vollan
Comment 3 2020-11-06 12:21:50 PST
Created attachment 413463 [details] Patch
Per Arne Vollan
Comment 4 2020-11-06 12:27:11 PST
Created attachment 413465 [details] Patch
Brent Fulgham
Comment 5 2020-11-06 12:44:11 PST
Comment on attachment 413465 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413465&action=review I had a few questions, but looks good. r=me > Source/WebKit/ChangeLog:9 > + Like on iOS, the WebContent process on macOS should have IOKit message filtering as well. No need for "as well" at the end (since you say "Like on iOS, ...") > Source/WebKit/ChangeLog:15 > + * WebProcess/com.apple.WebProcess.sb.in: Should we be making similar changes to the GPU Process sandbox? > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-139 > - (iokit-registry-entry-class "AppleGraphicsControlClient") So we do NOT need AppleGraphicsControlClient?
Per Arne Vollan
Comment 6 2020-11-06 12:59:37 PST
(In reply to Brent Fulgham from comment #5) > Comment on attachment 413465 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413465&action=review > > I had a few questions, but looks good. r=me > > > Source/WebKit/ChangeLog:9 > > + Like on iOS, the WebContent process on macOS should have IOKit message filtering as well. > > No need for "as well" at the end (since you say "Like on iOS, ...") > Will fix! > > Source/WebKit/ChangeLog:15 > > + * WebProcess/com.apple.WebProcess.sb.in: > > Should we be making similar changes to the GPU Process sandbox? > That is a good point. Would you be OK with doing this in a separate patch? > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-139 > > - (iokit-registry-entry-class "AppleGraphicsControlClient") > > So we do NOT need AppleGraphicsControlClient? Ah, good catch! Will fix. Thanks for reviewing!
Per Arne Vollan
Comment 7 2020-11-06 13:09:55 PST
Created attachment 413472 [details] Patch
EWS
Comment 8 2020-11-06 16:32:11 PST
Committed r269550: <https://trac.webkit.org/changeset/269550> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413472 [details].
Note You need to log in before you can comment on or make changes to this bug.