Bug 218654 - REGRESSION(r269503): [GTK][WPE] >200 tests are failing
Summary: REGRESSION(r269503): [GTK][WPE] >200 tests are failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Lord
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-06 03:01 PST by Diego Pino
Modified: 2020-11-09 02:19 PST (History)
10 users (show)

See Also:


Attachments
Patch (2.34 KB, patch)
2020-11-06 04:27 PST, Chris Lord
no flags Details | Formatted Diff | Diff
Patch (2.34 KB, patch)
2020-11-06 05:08 PST, Chris Lord
no flags Details | Formatted Diff | Diff
Patch (2.20 KB, patch)
2020-11-06 08:06 PST, Chris Lord
no flags Details | Formatted Diff | Diff
Patch (4.10 KB, patch)
2020-11-09 01:29 PST, Chris Lord
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2020-11-06 03:01:21 PST
More than 200 tests are failing in GTK and WPE since r269503 landed.

https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r269503%20(16840)/results.html
Comment 1 Chris Lord 2020-11-06 04:27:09 PST
Created attachment 413419 [details]
Patch
Comment 2 Chris Lord 2020-11-06 05:08:28 PST
Created attachment 413426 [details]
Patch
Comment 3 EWS 2020-11-06 05:47:10 PST
Committed r269508: <https://trac.webkit.org/changeset/269508>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413426 [details].
Comment 4 Radar WebKit Bug Importer 2020-11-06 05:48:58 PST
<rdar://problem/71116949>
Comment 5 Chris Lord 2020-11-06 08:03:05 PST
The last patch wasn't quite correct and caused some new test failures in canvas tests. Turns out it was over-complicated, will attach a fix.
Comment 6 Chris Lord 2020-11-06 08:06:35 PST
Created attachment 413433 [details]
Patch
Comment 7 Carlos Alberto Lopez Perez 2020-11-06 08:53:14 PST
The patch seems already reviewed. Do you need cq+?
Comment 8 Chris Lord 2020-11-06 08:59:40 PST
(In reply to Carlos Alberto Lopez Perez from comment #7)
> The patch seems already reviewed. Do you need cq+?

I pre-emptively filled the reviewed by field so I wouldn't have to re-upload, but it isn't reviewed yet. I think it's reasonably inert, but I'd like Zan's approval before cq+.
Comment 9 Lauro Moura 2020-11-08 20:22:10 PST
I've gardened the failures in r269572, separated from other gardening to make it easier to revert.

Testing locally, this second fix indeed fixes the issue for the 5 failing tests.
Comment 10 Chris Lord 2020-11-09 01:29:45 PST
Created attachment 413568 [details]
Patch
Comment 11 EWS 2020-11-09 02:19:56 PST
Committed r269578: <https://trac.webkit.org/changeset/269578>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413568 [details].