Bug 21864 - Add userData() and setUserData() methods to QWebHistoryItem.
Summary: Add userData() and setUserData() methods to QWebHistoryItem.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 21863
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-24 13:48 PDT by Yael
Modified: 2008-11-04 08:23 PST (History)
3 users (show)

See Also:


Attachments
Add new API (6.55 KB, patch)
2008-10-24 14:32 PDT, Yael
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2008-10-24 13:48:21 PDT
Add userData() and setUserData() methods to QWebHistoryItem. 
Also add signal QWebFrame::aboutToUpdateHistory(QWebHistoryItem*).
Comment 1 Yael 2008-10-24 14:32:05 PDT
Created attachment 24652 [details]
Add new API

Add new API.
Comment 2 Darin Adler 2008-11-03 09:35:04 PST
Why is this separate from bug 21863? It would be clearer to have a single patch for review than these two patches.
Comment 3 Yael 2008-11-03 10:02:07 PST
(In reply to comment #2)
> Why is this separate from bug 21863? It would be clearer to have a single patch
> for review than these two patches.
> 

Sorry for the confusion. I was told that it is easier to review patches if they are broken into smaller chunks. If that's not the case, I will not break my patches in the future. thanks!
Comment 4 Darin Adler 2008-11-03 10:25:38 PST
(In reply to comment #3)
> Sorry for the confusion. I was told that it is easier to review patches if they
> are broken into smaller chunks. If that's not the case, I will not break my
> patches in the future. thanks!

That is indeed true in general. But in this case, the chunks don't have any good logical separation -- there's just a lower level machinery that's unused and then adding the API to get at it.

Please don't take this as a general push to make patches larger in the future! It's good to break things up into the smallest sensible chunks that you can.
Comment 5 Simon Hausmann 2008-11-04 08:23:21 PST
Comment on attachment 24652 [details]
Add new API

Looks good! I'll do a few small cleanups before applying.
Comment 6 Simon Hausmann 2008-11-04 08:23:41 PST
Landed in r38097