Bug 218631 – DOMStringList, TextMetrics & ImageBitmapRenderingContext should be exposed to workers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

DOMStringList, TextMetrics & ImageBitmapRenderingContext should be exposed to workers:
- https://html.spec.whatwg.org/multipage/common-dom-interfaces.html#domstringlist
- https://html.spec.whatwg.org/multipage/canvas.html#textmetrics
- https://html.spec.whatwg.org/multipage/canvas.html#imagebitmaprenderingcontext

[Chris Dumez]

Created attachment 413336 [details]
Patch

[Chris Dumez]

Created attachment 413347 [details]
Patch

[Geoffrey Garen]

Comment on attachment 413347 [details]
Patch

How does ImageBitmapRenderingContext.canvas work on a worker? Is it always null?

Do we have any tests that exercise ImageBitmapRenderingContext in more detail on a worker?

[Chris Dumez]

(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 413347 [details]
> Patch
> 
> How does ImageBitmapRenderingContext.canvas work on a worker? Is it always
> null?
> 
> Do we have any tests that exercise ImageBitmapRenderingContext in more
> detail on a worker?

To be clear, this patch is not about exposing a particular functionality to workers. It merely exposes properties on the global WorkerGlobalScope.

To answer your question about ImageBitmapRenderingContext.canvas (although not really in the scope of this patch), the property can return either an HTMLCanvasElement or an OffscreenCanvas. In the case of workers, it would return an OffscreenCanvas. There is an implementation of OffscreenCanvas in WebKit but as far as I know is not enabled for Apple ports yet (not sure if the feature is complete or not).

[EWS]

Committed r269476: <https://trac.webkit.org/changeset/269476>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413347 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71095192>