NEW 218627
Introduce preference not to treat localhost and .localhost as mixed content
https://bugs.webkit.org/show_bug.cgi?id=218627
Summary Introduce preference not to treat localhost and .localhost as mixed content
Frédéric Wang (:fredw)
Reported 2020-11-05 11:02:38 PST
Created attachment 413325 [details] WIP Patch This is the part of bug 171934 that is controversial since we don't necessarily resolve localhost and .localhost to loopback addresses. Let's try with a disabled-by-default flag first.
Attachments
WIP Patch (2.13 KB, patch)
2020-11-05 11:02 PST, Frédéric Wang (:fredw)
no flags
Try 218623+218627 for EWS (73.23 KB, patch)
2020-11-11 08:30 PST, Frédéric Wang (:fredw)
ews-feeder: commit-queue-
Try 218623+218627 for EWS (84.06 KB, patch)
2020-11-12 03:05 PST, Frédéric Wang (:fredw)
ews-feeder: commit-queue-
Try 218623+218627 for EWS (87.92 KB, patch)
2020-11-12 05:39 PST, Frédéric Wang (:fredw)
ews-feeder: commit-queue-
WIP Patch (35.01 KB, patch)
2020-11-12 07:40 PST, Frédéric Wang (:fredw)
no flags
Try 218623+218627 for EWS (96.64 KB, patch)
2020-11-12 07:41 PST, Frédéric Wang (:fredw)
ews-feeder: commit-queue-
Patch (applies on top of bug 218623) (43.38 KB, patch)
2020-11-16 01:44 PST, Frédéric Wang (:fredw)
no flags
Patch (applies on top of bug 218623) (46.82 KB, patch)
2020-11-24 07:29 PST, Frédéric Wang (:fredw)
no flags
Patch (applies on top of bug 218623) (46.91 KB, patch)
2020-11-27 05:29 PST, Frédéric Wang (:fredw)
no flags
Radar WebKit Bug Importer
Comment 1 2020-11-09 11:34:09 PST
Frédéric Wang (:fredw)
Comment 2 2020-11-11 08:30:14 PST
Created attachment 413823 [details] Try 218623+218627 for EWS
Frédéric Wang (:fredw)
Comment 3 2020-11-12 03:05:20 PST
Created attachment 413922 [details] Try 218623+218627 for EWS
Frédéric Wang (:fredw)
Comment 4 2020-11-12 05:39:24 PST
Created attachment 413928 [details] Try 218623+218627 for EWS
EWS Watchlist
Comment 5 2020-11-12 05:40:17 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Frédéric Wang (:fredw)
Comment 6 2020-11-12 07:40:50 PST
Created attachment 413933 [details] WIP Patch
Frédéric Wang (:fredw)
Comment 7 2020-11-12 07:41:43 PST
Created attachment 413934 [details] Try 218623+218627 for EWS
Frédéric Wang (:fredw)
Comment 8 2020-11-16 01:44:24 PST
Created attachment 414202 [details] Patch (applies on top of bug 218623)
Alex Christensen
Comment 9 2020-11-16 10:26:17 PST
Comment on attachment 414202 [details] Patch (applies on top of bug 218623) What happens to the non-web-platform-tests if we just make the change without a preference?
Frédéric Wang (:fredw)
Comment 10 2020-11-24 07:11:10 PST
(In reply to Alex Christensen from comment #9) > Comment on attachment 414202 [details] > Patch (applies on top of bug 218623) > > What happens to the non-web-platform-tests if we just make the change > without a preference? They are failing because these tests assume loopback ip addresses and localhost addresses are mixed content. If we don't want to add the pref change, we would need something similar to what is done for WPT upstream in order to use different hostnames (see bug 127676).
Frédéric Wang (:fredw)
Comment 11 2020-11-24 07:29:10 PST
Created attachment 414841 [details] Patch (applies on top of bug 218623) Rebase
Frédéric Wang (:fredw)
Comment 12 2020-11-27 05:29:19 PST
Created attachment 414939 [details] Patch (applies on top of bug 218623)
Frédéric Wang (:fredw)
Comment 13 2021-12-10 02:12:40 PST
Removing myself from assignee since I'm not working on this anymore.
Note You need to log in before you can comment on or make changes to this bug.