Bug 218624 - Change RELEASE_ASSERT to use branch+crash inside HashTable.h
Summary: Change RELEASE_ASSERT to use branch+crash inside HashTable.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-05 10:39 PST by Saam Barati
Modified: 2020-11-05 15:02 PST (History)
7 users (show)

See Also:

Attachments
patch (2.88 KB, patch)
2020-11-05 10:56 PST, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
patch for landing (3.26 KB, patch)
2020-11-05 11:12 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-11-05 10:39:15 PST 
...
Comment 1 Saam Barati 2020-11-05 10:42:27 PST 
<rdar://problem/70901101>
Comment 2 Saam Barati 2020-11-05 10:56:36 PST 
Created attachment 413324 [details]
patch
Comment 3 Mark Lam 2020-11-05 11:02:55 PST 
Comment on attachment 413324 [details]
patch

r=me.  Can you introduce a HASH_TABLE_ASSERT macro to encapsulate this instead?  You can #undef it at the end of the file.
Comment 4 Mark Lam 2020-11-05 11:03:28 PST 
/HASH_TABLE_ASSERT/HASH_TABLE_RELEASE_ASSERT/
Comment 5 Saam Barati 2020-11-05 11:12:02 PST 
Created attachment 413328 [details]
patch for landing
Comment 6 EWS 2020-11-05 15:02:46 PST 
Committed r269478: <https://trac.webkit.org/changeset/269478>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413328 [details].