Bug 218613 - Enable llint asm on aarch64 when USE(64KB_PAGE_BLOCK) is enabled
Summary: Enable llint asm on aarch64 when USE(64KB_PAGE_BLOCK) is enabled
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
Depends on:
Reported: 2020-11-05 06:14 PST by Michael Catanzaro
Modified: 2020-11-25 15:13 PST (History)
10 users (show)

See Also:

Patch (1.92 KB, patch)
2020-11-05 06:46 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-11-05 06:14:53 PST
Bug #217989 forces cloop when USE(64KB_PAGE_BLOCK) is enabled. Xan recommends we use llint's assembler backend instead, since it is faster and bugs should be rare.
Comment 1 Michael Catanzaro 2020-11-05 06:46:55 PST
Created attachment 413291 [details]
Comment 2 Michael Catanzaro 2020-11-05 07:38:05 PST
(Mike: this reverses my previous recommendation that we should use cloop on aarch64.)
Comment 3 EWS 2020-11-09 10:53:54 PST
Committed r269586: <https://trac.webkit.org/changeset/269586>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413291 [details].
Comment 4 Michael Catanzaro 2020-11-25 14:36:40 PST
This doesn't build. Turns out aarch64 llint depends on JIT due to USE(JUMP_ISLANDS). It seems this configuration is maybe not as well-tested as we had hoped?

Let's follow-up in bug #219288.