RESOLVED FIXED218611
Test that skip_validation is effective 
https://bugs.webkit.org/show_bug.cgi?id=218611
Summary Test that skip_validation is effective
Angelos Oikonomopoulos
Reported 2020-11-05 05:22:57 PST
Test that skip_validation is effective
Attachments
Patch (1.65 KB, patch)
2020-11-05 05:24 PST, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Patch (1.65 KB, patch)
2020-11-05 06:01 PST, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Angelos Oikonomopoulos
Comment 1 2020-11-05 05:24:05 PST
Created attachment 413285 [details] Patch
Aakash Jain
Comment 2 2020-11-05 05:55:55 PST
Comment on attachment 413285 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413285&action=review looks good > Tools/CISupport/ews-build/steps_unittest.py:3603 > + self.setProperty('skip_validation', '1') Better to pass Boolean here
Angelos Oikonomopoulos
Comment 3 2020-11-05 06:01:11 PST
Created attachment 413288 [details] Patch
Angelos Oikonomopoulos
Comment 4 2020-11-05 06:02:55 PST
(In reply to Aakash Jain from comment #2) > Comment on attachment 413285 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413285&action=review > > looks good > > > Tools/CISupport/ews-build/steps_unittest.py:3603 > > + self.setProperty('skip_validation', '1') > > Better to pass Boolean here Fixed.
EWS
Comment 5 2020-11-05 06:44:33 PST
Committed r269429: <https://trac.webkit.org/changeset/269429> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413288 [details].
Radar WebKit Bug Importer
Comment 6 2020-11-05 06:45:53 PST
<rdar://problem/71076634>
Note You need to log in before you can comment on or make changes to this bug.