Bug 218565 – [css-grid] Move tests grid-columns-rows-get-set-multiple and grid-content-sized-columns-resolution to WPT folder

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

This patch moves the following tests

* grid-columns-rows-get-set-multiple.html
* grid-content-sized-columns-resolution.html

to WPT folder and removes their corresponding outdated versions from css-grid-layout folder

Created attachment 413273 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

Created attachment 413274 [details]
Patch

[Manuel Rego Casasnovas]

Comment on attachment 413274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413274&action=review

Thanks for doing this, just a minor change is required, the rest looks good to me.

> LayoutTests/ChangeLog:7
> +

I'd add here a small comment, explaining that these tests have been moved upstream in a Chromium change, linking the change or the WPT PR generated by the change.

> LayoutTests/imported/w3c/ChangeLog:12
> +

I believe we miss a change in "css/css-grid/parsing/w3c-import.log" to include the new tests.

These changes have been moved upstream in Chromium (https://chromium-review.googlesource.com/c/chromium/src/+/2436821) and ported in WPT (https://github.com/web-platform-tests/wpt/commit/7a287c9e26fbc12c91e1dde91859fabed96254b6)

Created attachment 413278 [details]
Patch

Created attachment 413280 [details]
Patch

[Manuel Rego Casasnovas]

Comment on attachment 413280 [details]
Patch

r=me, thanks!

Let's wait for the EWSs to be green before landing.

[EWS]

Committed r269426: <https://trac.webkit.org/changeset/269426>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413280 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71074866>