Bug 218565 - [css-grid] Move tests grid-columns-rows-get-set-multiple and grid-content-sized-columns-resolution to WPT folder
Summary: [css-grid] Move tests grid-columns-rows-get-set-multiple and grid-content-siz...
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2020-11-04 07:14 PST by zsun
Modified: 2020-11-05 05:12 PST (History)
7 users (show)

See Also:

Patch (94.99 KB, patch)
2020-11-05 01:57 PST, zsun
no flags Details | Formatted Diff | Diff
Patch (94.99 KB, patch)
2020-11-05 02:01 PST, zsun
no flags Details | Formatted Diff | Diff
Patch (96.22 KB, patch)
2020-11-05 02:35 PST, zsun
no flags Details | Formatted Diff | Diff
Patch (96.56 KB, patch)
2020-11-05 03:01 PST, zsun
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zsun 2020-11-04 07:14:28 PST
This patch moves the following tests

* grid-columns-rows-get-set-multiple.html
* grid-content-sized-columns-resolution.html

to WPT folder and removes their corresponding outdated versions from css-grid-layout folder
Comment 1 zsun 2020-11-05 01:57:45 PST
Created attachment 413273 [details]
Comment 2 EWS Watchlist 2020-11-05 01:58:58 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 zsun 2020-11-05 02:01:40 PST
Created attachment 413274 [details]
Comment 4 Manuel Rego Casasnovas 2020-11-05 02:10:22 PST
Comment on attachment 413274 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=413274&action=review

Thanks for doing this, just a minor change is required, the rest looks good to me.

> LayoutTests/ChangeLog:7
> +

I'd add here a small comment, explaining that these tests have been moved upstream in a Chromium change, linking the change or the WPT PR generated by the change.

> LayoutTests/imported/w3c/ChangeLog:12
> +

I believe we miss a change in "css/css-grid/parsing/w3c-import.log" to include the new tests.
Comment 6 zsun 2020-11-05 02:35:12 PST
Created attachment 413278 [details]
Comment 7 zsun 2020-11-05 03:01:57 PST
Created attachment 413280 [details]
Comment 8 Manuel Rego Casasnovas 2020-11-05 03:06:57 PST
Comment on attachment 413280 [details]

r=me, thanks!

Let's wait for the EWSs to be green before landing.
Comment 9 EWS 2020-11-05 05:11:25 PST
Committed r269426: <https://trac.webkit.org/changeset/269426>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413280 [details].
Comment 10 Radar WebKit Bug Importer 2020-11-05 05:12:29 PST