Bug 218544 – Remove more functions that implicitly use composed tree

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Darin Adler]

Remove more functions that implicitly use composed tree

[Darin Adler]

Created attachment 413121 [details]
Patch

[Darin Adler]

Created attachment 413124 [details]
Patch

[Darin Adler]

Comment on attachment 413124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413124&action=review

> Source/WebCore/editing/VisiblePosition.cpp:828
> +    auto midpoint = checkedSum<uint64_t>(characterRange.location, characterRange.length / 2);
> +    if (midpoint.hasOverflowed())
> +        return { };

Since these are actual computed sizes of a document already in memory, I don’t see any way we’d actually need checked arithmetic, so this should probably be changed to normal arithmetic.

[Darin Adler]

(In reply to Darin Adler from comment #3)
> Since these are actual computed sizes of a document already in memory, I
> don’t see any way we’d actually need checked arithmetic, so this should
> probably be changed to normal arithmetic.

Or I can write a separate midpoint function that takes a CharacterRange, and clamps end to the maximum value of uint64_t rather than treating it as an error. Should be safe/practical for our uses.

[Darin Adler]

Committed r269442: <https://trac.webkit.org/changeset/269442>

[Radar WebKit Bug Importer]

<rdar://problem/71081440>

[Ryosuke Niwa]

*** Bug 217313 has been marked as a duplicate of this bug. ***