Bug 218530 - align-content should be a discrete animatable property
Summary: align-content should be a discrete animatable property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar, WebExposed
Depends on:
Blocks:
 
Reported: 2020-11-03 12:40 PST by Antoine Quint
Modified: 2020-11-03 14:17 PST (History)
9 users (show)

See Also:


Attachments
Patch (12.50 KB, patch)
2020-11-03 12:42 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (14.54 KB, patch)
2020-11-03 13:37 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-11-03 12:40:57 PST
align-content should be a discrete animatable property
Comment 1 Antoine Quint 2020-11-03 12:42:12 PST
Created attachment 413093 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-11-03 13:00:32 PST
Comment on attachment 413093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413093&action=review

> Source/WebCore/rendering/style/StyleContentAlignmentData.cpp:17
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Library General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Library General Public License for more details.
> + *
> + * You should have received a copy of the GNU Library General Public License
> + * along with this library; see the file COPYING.LIB.  If not, write to
> + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + * Boston, MA 02110-1301, USA.

Wrong license.
Comment 3 Antoine Quint 2020-11-03 13:37:13 PST
Created attachment 413102 [details]
Patch for landing
Comment 4 Radar WebKit Bug Importer 2020-11-03 13:39:27 PST
<rdar://problem/71009339>
Comment 5 EWS 2020-11-03 14:17:20 PST
Committed r269333: <https://trac.webkit.org/changeset/269333>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413102 [details].