Bug 218522 - [WinCairo/PlayStation] ICU 68.1 no longer exposes FALSE and TRUE macros by default
Summary: [WinCairo/PlayStation] ICU 68.1 no longer exposes FALSE and TRUE macros by de...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-03 10:21 PST by Stephan Szabo
Modified: 2020-11-03 12:07 PST (History)
12 users (show)

See Also:

Attachments
Patch (8.83 KB, patch)
2020-11-03 10:25 PST, Stephan Szabo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2020-11-03 10:21:04 PST 
ICU 68.1 has stopped defining TRUE and FALSE macros by default (you can turn it on with a define, however it's also described as deprecated in some places).

Building using ICU 68.1 for WinCairo and PlayStation shows some places that fail to build without the definitions.
Comment 1 Stephan Szabo 2020-11-03 10:25:55 PST 
Created attachment 413070 [details]
Patch
Comment 2 EWS 2020-11-03 12:06:21 PST 
Committed r269325: <https://trac.webkit.org/changeset/269325>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413070 [details].
Comment 3 Radar WebKit Bug Importer 2020-11-03 12:07:23 PST 
<rdar://problem/71005244>