Bug 218498 - Make functional WebRTC encoders in GPUProcess
Summary: Make functional WebRTC encoders in GPUProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 218445
Blocks:
  Show dependency tree / graph
 
Reported: 2020-11-03 03:30 PST by youenn fablet
Modified: 2020-11-04 10:28 PST (History)
10 users (show)

See Also:

Attachments
Patch (46.70 KB, patch)
2020-11-03 05:34 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Fix iOS build (48.73 KB, patch)
2020-11-04 01:22 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-11-03 03:30:47 PST 
Make functional WebRTC encoders in GPUProcess
Comment 1 youenn fablet 2020-11-03 05:34:34 PST 
Created attachment 413052 [details]
Patch
Comment 2 Eric Carlson 2020-11-03 09:11:17 PST 
Comment on attachment 413052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413052&action=review

> Source/ThirdParty/libwebrtc/ChangeLog:8
> +        Add support for a remote encoder and remote factory that will first try to create a  remote encoder and use an in process encoder otherwise.

Nit: extra space between "a" and "remote"
Comment 3 youenn fablet 2020-11-04 01:22:00 PST 
Created attachment 413146 [details]
Fix iOS build
Comment 4 EWS 2020-11-04 10:27:11 PST 
Committed r269371: <https://trac.webkit.org/changeset/269371>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413146 [details].
Comment 5 Radar WebKit Bug Importer 2020-11-04 10:28:24 PST 
<rdar://problem/71041954>