Bug 21849 – A minor build failure on Japanese versions of Windows

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Platform

[Hironori Bono]

Steps to reproduce:
Build WebKit (Revision 37759) on the Japanese version of Windows XP (or Vista) with the "WebKitTOols/Script/build-webkit" script.

Actual Results:
The C++ compiler of Visual Studio 2005 treats a multiplication sign '×' (U+00D7) as corrupted SHIFT-JIS characters and outputs an error and a warning while compiling "WebKit/win/WebCoreLocalizedString.cpp".
  4>WebCoreLocalizedStrings.cpp
  4>..\WebCoreLocalizedStrings.cpp : error C2220: warning treated as error - no 'object' file generated
  4>..\WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss

Expected Results:
The compiler can compile the file without errors or warnings.

Build Date and Platform:
Revision 37759 (2008-10-21) on Windows XP SP2 and Vista SP1.

Additional Builds and Platforms:
- Does not occur on
The English version of Windows XP

Additional Information:
- Possible Solutions
The simplest solution is changing the system locale to English (US) in compiling WebKit.
Another solution is replacing the multiplication sign (U+00D7) with the quated expression of its UTF-8 value (0xC3 0x97), i.e. "\xC3\x97".

[Hironori Bono]

Created attachment 24632 [details]
A Quick Fix

This patch just replaces the multiplication sign (U+00D7) with the quated expression of its UTF-8 value (0xC3 0x97), i.e. "\xC3\x97".

[David Levin]

Although entered later, bug 26375 seems to be progressing in addressing the same issue.

*** This bug has been marked as a duplicate of 26375 ***