Bug 21847 - MIMETypeRegistry.cpp uses #if PLATFORM(CG), should it look for CF?
Summary: MIMETypeRegistry.cpp uses #if PLATFORM(CG), should it look for CF?
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-23 18:29 PDT by Mark Mentovai
Modified: 2008-10-24 10:32 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Mentovai 2008-10-23 18:29:55 PDT
In WebCore/platform/MIMETypeRegistry.cpp, initializeSupportedImageMIMETypes and initializeSupportedImageMIMETypesForEncoding both have some code that's #if PLATFORM(CG), gating what looks more like CF code having nothing to do with graphics.  Should these #ifs change to #if PLATFORM(CF)?
Comment 1 Sam Weinig 2008-10-23 19:08:47 PDT
The #if PLATFORM(CG) in initializeSupportedImageMIMETypes and initializeSupportedImageMIMETypesForEncoding are CG related because it calls CGImageSourceCopyTypeIdentifiers() and CGImageDestinationCopyTypeIdentifiers().  The getMIMETypeForUTI is also  #if PLATFORM(CG)  that way because it is a helper that is only called from other #if PLATFORM(CG)  in the file. 

What were you thinking was CFish and not CGish?
Comment 2 Mark Mentovai 2008-10-24 10:32:22 PDT
The CG calls were at the ends of long lines and I guess I missed them in the sea of CF.  You're right, there's definitely CG in there.